Fix more clang-tidy unhappines

6 years ago · b52adfeaee
parent 20b34d00c9
commit b52adfeaee
1 changed files with 3 additions and 3 deletions
--- a/part/pageviewannotator.cpp
+++ b/part/pageviewannotator.cpp
@ -334,7 +334,7 @@ class PickPointEngine2 : public PickPointEngine
            Okular::Annotation * ann = nullptr;

            Okular::CertificateStore* certStore = m_document->getCertStore();
-            QList<Okular::CertificateInfo*> certs = certStore->getSigningCertificates();
+            const QList<Okular::CertificateInfo*>& certs = certStore->getSigningCertificates();

            QStringList items;
            for( auto cert : certs )
@ -899,8 +899,8 @@ QRect PageViewAnnotator::performRouteMouseOrTabletEvent(const AnnotatorEngine::E

    if (signatureMode() && eventType == AnnotatorEngine::Press) {
        QDomElement elem;
-        elem.setTagName("engine");
-        elem.setAttribute("block", 1);
+        elem.setTagName(QStringLiteral("engine"));
+        elem.setAttribute(QStringLiteral("block"), 1);
        m_engine = new PickPointEngine2(elem, m_document);
    }