Removed useless Tile::operator=

core/tile.h

@@ -42,8 +42,6 @@ class OKULAR_EXPORT Tile
          */
         bool isValid() const;
 
-        Tile & operator=( const Tile &t );
-
     private:
         class Private;
         Private * d;

core/tilesmanager.cpp

@@ -613,19 +613,6 @@ Tile::Tile( const Tile &t )
     d->isValid = t.d->isValid;
 }
 
-Tile & Tile::operator=( const Tile &t )
-{
-    if ( this == &t )
-        return *this;
-
-    d = new Tile::Private;
-    d->rect = t.d->rect;
-    d->pixmap = t.d->pixmap;
-    d->isValid = t.d->isValid;
-
-    return *this;
-}
-
 Tile::~Tile()
 {
     delete d;

ui/pagepainter.cpp

@@ -249,7 +249,7 @@ void PagePainter::paintCroppedPageOnPainter( QPainter * destPainter, const Okula
             QList<Okular::Tile>::const_iterator tIt = tiles.constBegin(), tEnd = tiles.constEnd();
             while ( tIt != tEnd )
             {
-                Okular::Tile tile = *tIt;
+                const Okular::Tile &tile = *tIt;
                 QRect tileRect = tile.rect().geometry( scaledWidth, scaledHeight );
                 QRect limitsInTile = limits & tileRect;
                 if ( tile.pixmap() && !limitsInTile.isEmpty() )
@@ -305,7 +305,7 @@ void PagePainter::paintCroppedPageOnPainter( QPainter * destPainter, const Okula
             QList<Okular::Tile>::const_iterator tIt = tiles.constBegin(), tEnd = tiles.constEnd();
             while ( tIt != tEnd )
             {
-                Okular::Tile tile = *tIt;
+                const Okular::Tile &tile = *tIt;
                 QRect tileRect = tile.rect().geometry( scaledWidth, scaledHeight );
                 QRect limitsInTile = limits & tileRect;
                 if ( tile.pixmap() && !limitsInTile.isEmpty() )

ui/pageview.cpp

@@ -4133,7 +4133,7 @@ void PageView::slotRequestVisiblePixmaps( int newValue )
                 QList<Okular::Tile>::const_iterator tIt = tiles.constBegin(), tEnd = tiles.constEnd();
                 while ( tIt != tEnd )
                 {
-                    Okular::Tile tile = *tIt;
+                    const Okular::Tile &tile = *tIt;
                     if ( !tile.isValid() )
                     {
                         if ( tilesRect.isNull() )
@@ -4211,7 +4211,7 @@ void PageView::slotRequestVisiblePixmaps( int newValue )
                         QList<Okular::Tile>::const_iterator tIt = tiles.constBegin(), tEnd = tiles.constEnd();
                         while ( tIt != tEnd )
                         {
-                            Okular::Tile tile = *tIt;
+                            const Okular::Tile &tile = *tIt;
                             if ( !tile.isValid() )
                             {
                                 if ( tilesRect.isNull() )
@@ -4259,7 +4259,7 @@ void PageView::slotRequestVisiblePixmaps( int newValue )
                         QList<Okular::Tile>::const_iterator tIt = tiles.constBegin(), tEnd = tiles.constEnd();
                         while ( tIt != tEnd )
                         {
-                            Okular::Tile tile = *tIt;
+                            const Okular::Tile &tile = *tIt;
                             if ( !tile.isValid() )
                             {
                                 if ( tilesRect.isNull() )