Perform some initializations in initialization list

Fixes some variable is assigned in constructor body. Consider performing
initialization in initialization list. (CWE-398)
remotes/origin/work/svuorela/remove-write-only-variable-1
Willyanto Willyanto 3 years ago committed by Albert Astals Cid
parent 8a657e6d47
commit 647cdc40d0
  1. 14
      generators/chm/lib/ebook_chm.cpp
  2. 2
      generators/dvi/anchor.h
  3. 6
      generators/dvi/prebookmark.h
  4. 4
      generators/dvi/simplePageSize.h
  5. 2
      gui/certificatemodel.cpp

@ -28,15 +28,13 @@
EBook_CHM::EBook_CHM()
: EBook()
, m_chmFile(nullptr)
, m_detectedLCID(0)
, m_textCodec(nullptr)
, m_textCodecForSpecialFiles(nullptr)
, m_currentEncoding(QStringLiteral("UTF-8"))
, m_envOptions(QString::fromLatin1(qgetenv("KCHMVIEWEROPTS")))
{
m_envOptions = QString::fromLatin1(qgetenv("KCHMVIEWEROPTS"));
m_chmFile = nullptr;
m_filename = m_font = QString();
m_textCodec = nullptr;
m_textCodecForSpecialFiles = nullptr;
m_detectedLCID = 0;
m_currentEncoding = QStringLiteral("UTF-8");
}
EBook_CHM::~EBook_CHM()

@ -30,8 +30,8 @@ class Anchor
public:
/** \brief Constructs an anchor that points to an invalid page */
Anchor()
: page(0)
{
page = 0;
}
/** \brief Constructs an anchor that points to a given position on a

@ -23,10 +23,10 @@ public:
noOfChildren = 0;
}
PreBookmark(const QString &t, const QString &a, quint16 n)
: title(t)
, anchorName(a)
, noOfChildren(n)
{
title = t;
anchorName = a;
noOfChildren = n;
}
// Title of the bookmark

@ -48,9 +48,9 @@ public:
@param height
*/
SimplePageSize(const Length width, const Length height)
: pageWidth(width)
, pageHeight(height)
{
pageWidth = width;
pageHeight = height;
}
~SimplePageSize()

@ -17,9 +17,9 @@
CertificateModel::CertificateModel(const Okular::CertificateInfo &certInfo, QObject *parent)
: QAbstractTableModel(parent)
, m_certificateProperties({Version, SerialNumber, Issuer, IssuedOn, ExpiresOn, Subject, PublicKey, KeyUsage})
, m_certificateInfo(certInfo)
{
m_certificateProperties = {Version, SerialNumber, Issuer, IssuedOn, ExpiresOn, Subject, PublicKey, KeyUsage};
}
int CertificateModel::columnCount(const QModelIndex &) const

Loading…
Cancel
Save