From 630269a400bd2fd1f5a49388d2d37b44f70b8d3b Mon Sep 17 00:00:00 2001 From: Olivier CHURLAUD Date: Sun, 17 Jul 2016 02:28:57 +0200 Subject: [PATCH] More ports out of KDialog --- CMakeLists.txt | 1 + conf/dlgperformancebase.ui | 10 +----- ui/bookmarklist.cpp | 6 ++-- ui/fileprinterpreview.cpp | 35 +++++++++++------- ui/fileprinterpreview.h | 4 +-- ui/pageview.cpp | 72 ++------------------------------------ ui/presentationwidget.cpp | 7 ++-- 7 files changed, 36 insertions(+), 99 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 7734ed986..dc109d666 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -314,6 +314,7 @@ target_link_libraries(okularpart okularcore KF5::Archive KF5::Bookmarks KF5::IconThemes + KF5::ItemViews KF5::KDELibs4Support KF5::Parts KF5::Solid diff --git a/conf/dlgperformancebase.ui b/conf/dlgperformancebase.ui index 2e5c1ccc9..75b75307d 100644 --- a/conf/dlgperformancebase.ui +++ b/conf/dlgperformancebase.ui @@ -141,7 +141,7 @@ - + Memory Usage @@ -344,14 +344,6 @@ - - - KButtonGroup - QGroupBox -
kbuttongroup.h
- 1 -
-
kiconloader.h diff --git a/ui/bookmarklist.cpp b/ui/bookmarklist.cpp index e1acdbbf3..1450323c2 100644 --- a/ui/bookmarklist.cpp +++ b/ui/bookmarklist.cpp @@ -16,12 +16,12 @@ #include #include #include - +#include #include #include + #include -#include -#include +#include #include "pageitemdelegate.h" #include "core/action.h" diff --git a/ui/fileprinterpreview.cpp b/ui/fileprinterpreview.cpp index bfbbc158f..59d0059bf 100644 --- a/ui/fileprinterpreview.cpp +++ b/ui/fileprinterpreview.cpp @@ -14,11 +14,13 @@ #include #include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include #include #include #include @@ -44,6 +46,9 @@ public: , config(KSharedConfig::openConfig(QStringLiteral("okularrc"))) { + mainlayout = new QVBoxLayout(q); + buttonBox = new QDialogButtonBox(QDialogButtonBox::Close, q); + mainlayout->addWidget(buttonBox); filename = _filename; } @@ -55,6 +60,10 @@ public: QWidget *mainWidget; + QDialogButtonBox *buttonBox; + + QVBoxLayout *mainlayout; + QString filename; KParts::ReadOnlyPart *previewPart; @@ -111,7 +120,7 @@ bool FilePrinterPreviewPrivate::doPreview() fail(); return false; } else { - q->setMainWidget(previewPart->widget()); + mainlayout->insertWidget(0, previewPart->widget()); return previewPart->openUrl(QUrl::fromLocalFile(filename)); } } @@ -121,30 +130,30 @@ void FilePrinterPreviewPrivate::fail() if (!failMessage) { failMessage = new QLabel(i18n("Could not load print preview part"), q); } - q->setMainWidget(failMessage); + mainlayout->insertWidget(0, failMessage); } FilePrinterPreview::FilePrinterPreview( const QString &filename, QWidget *parent ) - : KDialog( parent ) + : QDialog( parent ) , d( new FilePrinterPreviewPrivate( this, filename ) ) { qCDebug(OkularUiDebug) << "kdeprint: creating preview dialog"; // Set up the dialog - setCaption(i18n("Print Preview")); - setButtons(KDialog::Close); - button(KDialog::Close)->setAutoDefault(false); + setWindowTitle(i18n("Print Preview")); + + connect(d->buttonBox, &QDialogButtonBox::rejected, this, &QDialog::reject); - restoreDialogSize(d->config->group("Print Preview")); + KWindowConfig::restoreWindowSize(windowHandle(), d->config->group("Print Preview")); } FilePrinterPreview::~FilePrinterPreview() { KConfigGroup group(d->config->group("Print Preview")); - saveDialogSize(group); + KWindowConfig::saveWindowSize(windowHandle(), group); delete d; } @@ -164,7 +173,7 @@ void FilePrinterPreview::showEvent(QShowEvent *event) return; } } - KDialog::showEvent(event); + QDialog::showEvent(event); } #include "moc_fileprinterpreview.cpp" diff --git a/ui/fileprinterpreview.h b/ui/fileprinterpreview.h index cca420d72..c3f3260b5 100644 --- a/ui/fileprinterpreview.h +++ b/ui/fileprinterpreview.h @@ -13,7 +13,7 @@ #ifndef FILEPRINTERPREVIEW_H #define FILEPRINTERPREVIEW_H -#include +#include namespace Okular { @@ -21,7 +21,7 @@ namespace Okular { class FilePrinterPreviewPrivate; -class FilePrinterPreview : public KDialog +class FilePrinterPreview : public QDialog { Q_OBJECT diff --git a/ui/pageview.cpp b/ui/pageview.cpp index 52b975b95..580db1888 100644 --- a/ui/pageview.cpp +++ b/ui/pageview.cpp @@ -35,18 +35,16 @@ #include #include #include +#include #include #include #include #include #include -#include -#include #include #include #include -#include #include #include #include @@ -659,7 +657,7 @@ void PageView::setupActions( KActionCollection * ac ) ac->addAction( QStringLiteral("speak_document"), d->aSpeakDoc ); d->aSpeakDoc->setEnabled( false ); connect( d->aSpeakDoc, &QAction::triggered, this, &PageView::slotSpeakDocument ); - + d->aSpeakPage = new QAction( QIcon::fromTheme( QStringLiteral("text-speak") ), i18n( "Speak Current Page" ), this ); ac->addAction( QStringLiteral("speak_current_page"), d->aSpeakPage ); d->aSpeakPage->setEnabled( false ); @@ -2765,8 +2763,7 @@ void PageView::mouseReleaseEvent( QMouseEvent * e ) else if ( choice == imageToFile ) { // [3] save pixmap to file - QString fileName = KFileDialog::getSaveFileName( QUrl(), QStringLiteral("image/png image/jpeg"), this, QString(), - KFileDialog::ConfirmOverwrite ); + QString fileName = QFileDialog::getSaveFileName(this, i18n("Save file"), QString(), i18n("Images (*.png .jpeg")); if ( fileName.isEmpty() ) d->messageWindow->display( i18n( "File not saved." ), QString(), PageViewMessage::Warning ); else @@ -4206,58 +4203,7 @@ void PageView::updatePageStep() { void PageView::addWebShortcutsMenu( QMenu * menu, const QString & text ) { -#if KDE_IS_VERSION(4,5,70) - if ( text.isEmpty() ) - { - return; - } - - QString searchText = text; - searchText = searchText.replace( QLatin1Char('\n'), QLatin1Char(' ') ).replace(QLatin1Char( '\r'), QLatin1Char(' ') ).simplified(); - - if ( searchText.isEmpty() ) - { - return; - } - - KUriFilterData filterData( searchText ); - - filterData.setSearchFilteringOptions( KUriFilterData::RetrievePreferredSearchProvidersOnly ); - - if ( KUriFilter::self()->filterSearchUri( filterData, KUriFilter::NormalTextFilter ) ) - { - const QStringList searchProviders = filterData.preferredSearchProviders(); - - if ( !searchProviders.isEmpty() ) - { - QMenu *webShortcutsMenu = new QMenu( menu ); - webShortcutsMenu->setIcon( QIcon::fromTheme( QStringLiteral("preferences-web-browser-shortcuts") ) ); - - const QString squeezedText = KStringHandler::rsqueeze( searchText, 21 ); - webShortcutsMenu->setTitle( i18n( "Search for '%1' with", squeezedText ) ); - QAction *action = 0; - - foreach( const QString &searchProvider, searchProviders ) - { - action = new QAction( searchProvider, webShortcutsMenu ); - action->setIcon( QIcon::fromTheme( filterData.iconNameForPreferredSearchProvider( searchProvider ) ) ); - action->setData( filterData.queryForPreferredSearchProvider( searchProvider ) ); - connect( action, &QAction::triggered, this, &PageView::slotHandleWebShortcutAction ); - webShortcutsMenu->addAction( action ); - } - - webShortcutsMenu->addSeparator(); - - action = new QAction( i18n( "Configure Web Shortcuts..." ), webShortcutsMenu ); - action->setIcon( QIcon::fromTheme( QStringLiteral("configure") ) ); - connect( action, &QAction::triggered, this, &PageView::slotConfigureWebShortcuts ); - webShortcutsMenu->addAction( action ); - - menu->addMenu(webShortcutsMenu); - } - } -#endif } //BEGIN private SLOTS @@ -4752,19 +4698,7 @@ void PageView::slotShowSizeAllCursor() void PageView::slotHandleWebShortcutAction() { -#if KDE_IS_VERSION(4,5,70) - QAction *action = qobject_cast( sender() ); - - if (action) - { - KUriFilterData filterData( action->data().toString() ); - if ( KUriFilter::self()->filterSearchUri( filterData, KUriFilter::WebShortcutFilter ) ) - { - KToolInvocation::invokeBrowser( filterData.uri().url() ); - } - } -#endif } void PageView::slotConfigureWebShortcuts() diff --git a/ui/presentationwidget.cpp b/ui/presentationwidget.cpp index b2a74a748..b95ca9181 100644 --- a/ui/presentationwidget.cpp +++ b/ui/presentationwidget.cpp @@ -39,7 +39,7 @@ #include #include #include -#include +#include #include @@ -149,7 +149,8 @@ PresentationWidget::PresentationWidget( QWidget * parent, Okular::Document * doc if ( caption.trimmed().isEmpty() ) caption = doc->currentDocument().fileName(); caption = i18nc( "[document title/filename] – Presentation", "%1 – Presentation", caption ); - setWindowTitle( KDialog::makeStandardCaption( caption ) ); + setWindowTitle( caption ); +#pragma message("KF5: Here was a makeStandardCaption, lost in KF5 port") m_width = -1; m_screen = -2; @@ -235,7 +236,7 @@ PresentationWidget::PresentationWidget( QWidget * parent, Okular::Document * doc m_overlayHideTimer = new QTimer( this ); m_overlayHideTimer->setSingleShot( true ); connect(m_overlayHideTimer, &QTimer::timeout, this, &PresentationWidget::slotHideOverlay); - m_nextPageTimer = new QTimer( this ); + m_nextPageTimer = new QTimer( this ); m_nextPageTimer->setSingleShot( true ); connect(m_nextPageTimer, &QTimer::timeout, this, &PresentationWidget::slotNextPage);