diff --git a/conf/okular.kcfg b/conf/okular.kcfg index e5ed8ebbd..66d667571 100644 --- a/conf/okular.kcfg +++ b/conf/okular.kcfg @@ -11,7 +11,7 @@ - + true @@ -322,13 +322,13 @@ true - - AnnotationToolBar + + FullAnnotationToolBar - + - + Single diff --git a/part/annotationactionhandler.cpp b/part/annotationactionhandler.cpp index 474790b11..dd246bcdb 100644 --- a/part/annotationactionhandler.cpp +++ b/part/annotationactionhandler.cpp @@ -769,7 +769,7 @@ AnnotationActionHandler::AnnotationActionHandler(PageViewAnnotator *parent, KAct ac->setDefaultShortcut(d->aAddToQuickTools, QKeySequence(Qt::CTRL + Qt::SHIFT + Qt::Key_B)); d->updateConfigActions(); - connect(Okular::Settings::self(), &Okular::Settings::defaultAnnotationToolBarChanged, this, &AnnotationActionHandler::setupAnnotationToolBarVisibilityAction); + connect(Okular::Settings::self(), &Okular::Settings::primaryAnnotationToolBarChanged, this, &AnnotationActionHandler::setupAnnotationToolBarVisibilityAction); } AnnotationActionHandler::~AnnotationActionHandler() @@ -797,16 +797,16 @@ void AnnotationActionHandler::setupAnnotationToolBarVisibilityAction() // hide action connect(d->aHideToolBar, &QAction::triggered, annotationToolBar, &KToolBar::hide, Qt::UniqueConnection); - KToolBar *defaultAnnotationToolBar = annotationToolBar; - if (Okular::Settings::defaultAnnotationToolBar() == Okular::Settings::EnumDefaultAnnotationToolBar::QuickAnnotationToolBar) { - defaultAnnotationToolBar = mw->toolBar(QStringLiteral("quickAnnotationToolBar")); + KToolBar *primaryAnnotationToolBar = annotationToolBar; + if (Okular::Settings::primaryAnnotationToolBar() == Okular::Settings::EnumPrimaryAnnotationToolBar::QuickAnnotationToolBar) { + primaryAnnotationToolBar = mw->toolBar(QStringLiteral("quickAnnotationToolBar")); } d->aToolBarVisibility->setChecked(false); d->aToolBarVisibility->disconnect(); - d->aToolBarVisibility->setChecked(defaultAnnotationToolBar->isVisible()); - connect(defaultAnnotationToolBar, &QToolBar::visibilityChanged, d->aToolBarVisibility, &QAction::setChecked, Qt::UniqueConnection); - connect(d->aToolBarVisibility, &QAction::toggled, defaultAnnotationToolBar, &KToolBar::setVisible, Qt::UniqueConnection); - d->aShowToolBar->setEnabled(!defaultAnnotationToolBar->isVisible()); + d->aToolBarVisibility->setChecked(primaryAnnotationToolBar->isVisible()); + connect(primaryAnnotationToolBar, &QToolBar::visibilityChanged, d->aToolBarVisibility, &QAction::setChecked, Qt::UniqueConnection); + connect(d->aToolBarVisibility, &QAction::toggled, primaryAnnotationToolBar, &KToolBar::setVisible, Qt::UniqueConnection); + d->aShowToolBar->setEnabled(!primaryAnnotationToolBar->isVisible()); } void AnnotationActionHandler::reparseBuiltinToolsConfig() diff --git a/part/dlgannotations.cpp b/part/dlgannotations.cpp index a81a35c57..58b703c00 100644 --- a/part/dlgannotations.cpp +++ b/part/dlgannotations.cpp @@ -20,12 +20,13 @@ DlgAnnotations::DlgAnnotations(QWidget *parent) { QFormLayout *layout = new QFormLayout(this); - // Combobox: default annotation toolbar associated to annotation action in tool menu - QComboBox *annotationToolBar = new QComboBox(this); - annotationToolBar->addItem(i18nc("item:inlistbox Config dialog, general page", "Full Annotation Toobar")); - annotationToolBar->addItem(i18nc("item:inlistbox Config dialog, general page", "Quick Annotation Toolbar")); - annotationToolBar->setObjectName(QStringLiteral("kcfg_AnnotationToolBar")); - layout->addRow(i18nc("label:listbox Config dialog, general page", "Annotation toolbar:"), annotationToolBar); + // BEGIN Annotation toolbar: Combo box to set the annotation toolbar associated to annotation action in tool menu + QComboBox *primaryAnnotationToolBar = new QComboBox(this); + primaryAnnotationToolBar->addItem(i18nc("item:inlistbox Config dialog, general page", "Full Annotation Toobar")); + primaryAnnotationToolBar->addItem(i18nc("item:inlistbox Config dialog, general page", "Quick Annotation Toolbar")); + primaryAnnotationToolBar->setObjectName(QStringLiteral("kcfg_PrimaryAnnotationToolBar")); + layout->addRow(i18nc("label:listbox Config dialog, general page", "Annotation toolbar:"), primaryAnnotationToolBar); + // END Annotation toolbar // BEGIN Author row: Line edit to set the annotation’s default author value. QLineEdit *authorLineEdit = new QLineEdit(this);