Stop leaking qfiledialogs

10 years ago · 57fd20e90e
parent 1cd0bb2697
commit 57fd20e90e
1 changed files with 8 additions and 5 deletions
--- a/shell/shell.cpp
+++ b/shell/shell.cpp
@ -463,12 +463,15 @@ void Shell::fileOpen()
    dlg->setNameFilters( namePatterns );

    dlg->setWindowTitle( i18n("Open Document") );
-    if ( !dlg->exec() || !dlg)
-        return;
+    if ( dlg->exec() && dlg ) {
+        foreach(const QUrl& url, dlg->selectedUrls())
+        {
+            openUrl( url );
+        }
+    }

-    foreach(const QUrl& url, dlg->selectedUrls())
-    {
-        openUrl( url );
+    if ( dlg ) {
+        delete dlg.data();
    }
 }