From 0eb2f227b09346f4bf8985ed471e353ddcd2bfee Mon Sep 17 00:00:00 2001 From: Albert Astals Cid Date: Sun, 27 Aug 2017 13:18:31 +0200 Subject: [PATCH] Fix memory leak in text document settings d-pointers --- core/textdocumentsettings.cpp | 3 ++- core/textdocumentsettings_p.h | 6 +++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/core/textdocumentsettings.cpp b/core/textdocumentsettings.cpp index b6b4c54a5..01b98e2e7 100644 --- a/core/textdocumentsettings.cpp +++ b/core/textdocumentsettings.cpp @@ -46,6 +46,7 @@ TextDocumentSettingsWidget::~TextDocumentSettingsWidget() Q_D( TextDocumentSettingsWidget ); delete d->mUi; + delete d; } void TextDocumentSettingsWidget::addRow( const QString& labelText, QWidget *widget ) @@ -62,7 +63,7 @@ void TextDocumentSettingsWidget::addRow( const QString& labelText, QWidget *widg TextDocumentSettings::TextDocumentSettings( const QString& config, QObject *parent ) : KConfigSkeleton( config, parent ) - , d_ptr( new TextDocumentSettingsPrivate() ) + , d_ptr( new TextDocumentSettingsPrivate(this) ) { Q_D( TextDocumentSettings ); diff --git a/core/textdocumentsettings_p.h b/core/textdocumentsettings_p.h index 5104de25b..5f09ba605 100644 --- a/core/textdocumentsettings_p.h +++ b/core/textdocumentsettings_p.h @@ -31,9 +31,13 @@ class TextDocumentSettingsWidgetPrivate Ui_TextDocumentSettings *mUi; }; -class TextDocumentSettingsPrivate +class TextDocumentSettingsPrivate : public QObject { public: + TextDocumentSettingsPrivate(QObject *parent) + : QObject(parent) + {} + QFont mFont; };