From 08a76adda1b29b33cdb7f7430be231595e109aed Mon Sep 17 00:00:00 2001 From: Arshad Husain Date: Mon, 11 May 2020 09:15:50 +0200 Subject: [PATCH] Do not show dialog when reloading file that requests fullscreen When using Okular as previewer in PDFTex workflow, preparing beamer slides, the following usability hell occurred: * LaTex/Beamer slides should be compiled to PDF with metadata "StartFullScreen" * But while editing, on every PDF change/and reload, the user gets a modal popup "The document requested to be launched in presentation mode." "Do you want to allow it?" BUG: 361740 --- part.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/part.cpp b/part.cpp index 721080986..0ba257899 100644 --- a/part.cpp +++ b/part.cpp @@ -1702,7 +1702,7 @@ bool Part::openFile() // if the 'StartFullScreen' flag is set and we're not in viewer widget mode, or the command line flag was // specified, start presentation const bool presentationBecauseOfDocumentMetadata = ( m_embedMode != ViewerWidgetMode ) && m_document->metaData( QStringLiteral("StartFullScreen") ).toBool(); - if ( presentationBecauseOfDocumentMetadata || m_cliPresentation ) + if ( ( presentationBecauseOfDocumentMetadata || m_cliPresentation ) && !m_isReloading ) { bool goAheadWithPresentationMode = true; if ( !m_cliPresentation )