make use of gcc's __attribute__ extension

src/ncmpcpp.cpp

@@ -1344,7 +1344,7 @@ int main(int argc, char *argv[])
 				if (newpos > 0 && newpos < 100)
 					Mpd->Seek(s->GetTotalLength()*newpos/100.0);
 				else
-					ShowMessage("Out of bounds, 1-99 possible for %, %d given.", newpos);
+					ShowMessage("Out of bounds, 1-99 possible for %%, %d given.", newpos);
 			}
 			UpdateStatusImmediately = 1;
 		}

src/status.h

@@ -35,7 +35,7 @@ void NcmpcppStatusChanged(MPD::Connection *, MPD::StatusChanges, void *);
 void NcmpcppErrorCallback(MPD::Connection *, int, const char *, void *);
 
 Window &Statusbar();
-void ShowMessage(const char *, ...);
+void ShowMessage(const char *, ...) GNUC_PRINTF(1, 2);
 
 void StatusbarGetStringHelper(const std::wstring &);
 void StatusbarApplyFilterImmediately(const std::wstring &);

src/window.cpp

@@ -33,7 +33,7 @@ using namespace NCurses;
 using std::string;
 using std::wstring;
 
-void NCurses::InitScreen(const char *window_title, bool enable_colors)
+void NCurses::InitScreen(GNUC_UNUSED const char *window_title, bool enable_colors)
 {
 	const int ColorsTable[] =
 	{
@@ -44,7 +44,6 @@ void NCurses::InitScreen(const char *window_title, bool enable_colors)
 #	ifdef XCURSES
 	Xinitscr(1, const_cast<char **>(&window_title));
 #	else
-	window_title = 0; // silence compiler
 	initscr();
 #	endif // XCURSES
 	if (has_colors() && enable_colors)

src/window.h

@@ -31,6 +31,14 @@
 #include <vector>
 #include <string>
 
+#if defined(__GNUC__) && __GNUC__ >= 3
+# define GNUC_UNUSED __attribute__((unused))
+# define GNUC_PRINTF(a, b) __attribute__((format(printf, a, b)))
+#else
+# define GNUC_UNUSED
+# define GNUC_PRINTF(a, b)
+#endif
+
 #ifdef USE_PDCURSES
 # undef KEY_BACKSPACE
 # define KEY_BACKSPACE 8