menu: remove Menu::hasSelected

src/actions.cpp

@@ -797,7 +797,7 @@ void Delete::Run()
 			return;
 		
 		std::string question;
-		if (myBrowser->main().hasSelected())
+		if (hasSelected(myBrowser->main().begin(), myBrowser->main().end()))
 			question = "Delete selected items?";
 		else
 		{
@@ -846,7 +846,7 @@ void Delete::Run()
 		if (myScreen->isActiveWindow(myPlaylistEditor->Playlists))
 		{
 			std::string question;
-			if (myPlaylistEditor->Playlists.hasSelected())
+			if (hasSelected(myPlaylistEditor->Playlists.begin(), myPlaylistEditor->Playlists.end()))
 				question = "Delete selected playlists?";
 			else
 			{

src/menu.h

@@ -239,10 +239,6 @@ public:
 	/// @return true if the position is reachable, false otherwise
 	bool Goto(size_t y);
 	
-	/// Checks whether list contains selected positions
-	/// @return true if it contains them, false otherwise
-	bool hasSelected() const;
-	
 	/// Highlights given position
 	/// @param pos position to be highlighted
 	void highlight(size_t pos);
@@ -774,14 +770,6 @@ template <typename T> void Menu<T>::clear()
 	m_options_ptr = &m_options;
 }
 
-template <typename T> bool Menu<T>::hasSelected() const
-{
-	for (auto it = begin(); it != end(); ++it)
-		if (it->isSelected())
-			return true;
-	return false;
-}
-
 template <typename T> void Menu<T>::highlight(size_t pos)
 {
 	assert(pos < m_options_ptr->size());

src/sort_playlist.cpp

@@ -20,6 +20,7 @@
 
 #include "display.h"
 #include "global.h"
+#include "helpers.h"
 #include "playlist.h"
 #include "settings.h"
 #include "sort_playlist.h"
@@ -156,7 +157,7 @@ void SortPlaylistDialog::sort() const
 	auto &pl = myPlaylist->main();
 	auto begin = pl.begin(), end = pl.end();
 	// if songs are selected, sort range from first selected to last selected
-	if (pl.hasSelected())
+	if (hasSelected(pl.begin(), pl.end()))
 	{
 		while (!begin->isSelected())
 			++begin;

src/tag_editor.cpp

@@ -451,7 +451,8 @@ void TagEditor::enterPressed()
 		return;
 	
 	EditedSongs.clear();
-	if (Tags->hasSelected()) // if there are selected songs, perform operations only on them
+	// if there are selected songs, perform operations only on them
+	if (hasSelected(Tags->begin(), Tags->end()))
 	{
 		for (auto it = Tags->begin(); it != Tags->end(); ++it)
 			if (it->isSelected())