From 3cc76ff0c49d5569cbdbafc34382dbad5cf4794f Mon Sep 17 00:00:00 2001 From: Andrzej Rybczak Date: Sat, 15 Nov 2014 19:29:31 +0100 Subject: [PATCH] charset: pass const references --- src/charset.cpp | 8 ++++---- src/charset.h | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/charset.cpp b/src/charset.cpp index 05ca1e62..9e91a1d3 100644 --- a/src/charset.cpp +++ b/src/charset.cpp @@ -44,24 +44,24 @@ std::locale internalLocale() return loc; } -std::string toUtf8From(std::string s, const char *charset) +std::string toUtf8From(const std::string &s, const char *charset) { return boost::locale::conv::to_utf(s, charset); } -std::string fromUtf8To(std::string s, const char *charset) +std::string fromUtf8To(const std::string &s, const char *charset) { return boost::locale::conv::to_utf(s, charset); } -std::string utf8ToLocale(std::string s) +std::string utf8ToLocale(const std::string &s) { return Config.system_encoding.empty() ? s : boost::locale::conv::from_utf(s, Config.system_encoding); } -std::string localeToUtf8(std::string s) +std::string localeToUtf8(const std::string &s) { return Config.system_encoding.empty() ? s diff --git a/src/charset.h b/src/charset.h index b28aae3d..2b335663 100644 --- a/src/charset.h +++ b/src/charset.h @@ -28,11 +28,11 @@ namespace Charset { std::locale internalLocale(); -std::string toUtf8From(std::string s, const char *charset); -std::string fromUtf8To(std::string s, const char *charset); +std::string toUtf8From(const std::string &s, const char *charset); +std::string fromUtf8To(const std::string &s, const char *charset); -std::string utf8ToLocale(std::string s); -std::string localeToUtf8(std::string s); +std::string utf8ToLocale(const std::string &s); +std::string localeToUtf8(const std::string &s); }