From 0c88287c03d6272e0574377cbd3c9ff6de48a49c Mon Sep 17 00:00:00 2001 From: Andrzej Rybczak Date: Sun, 21 May 2017 15:24:27 +0200 Subject: [PATCH] Add virtual destructors to base classes --- src/actions.h | 4 +++- src/lyrics_fetcher.h | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/actions.h b/src/actions.h index c4444df9..9d01d632 100644 --- a/src/actions.h +++ b/src/actions.h @@ -189,7 +189,9 @@ extern size_t FooterStartY; struct BaseAction { BaseAction(Type type_, const char *name_): m_name(name_), m_type(type_) { } - + + virtual ~BaseAction() { } + const std::string &name() const { return m_name; } Type type() const { return m_type; } diff --git a/src/lyrics_fetcher.h b/src/lyrics_fetcher.h index f6578175..695e50f3 100644 --- a/src/lyrics_fetcher.h +++ b/src/lyrics_fetcher.h @@ -29,7 +29,9 @@ struct LyricsFetcher { typedef std::pair Result; - + + virtual ~LyricsFetcher() { } + virtual const char *name() const = 0; virtual Result fetch(const std::string &artist, const std::string &title);