Summary:
In order to separate favorites from the "entity order" QSFPM
used by the folder tree widget (it was always weird that filtering or
changing the sort order for the folder tree widget would affect favorites),
we need the favorites to get their own "ordering" proxy (otherwise
ordering is random, based on ETM population order). So while at it,
I implemented manual reordering of favorites.
BUG: 376073
FIXED-IN: 18.04
Test Plan:
I can reorder favorites (in listview mode) using DnD
and the order is persisted
Reviewers: dvratil, mlaurent
Reviewed By: mlaurent
Subscribers: #kde_pim
Tags: #kde_pim
Differential Revision: https://phabricator.kde.org/D8884
This includes testing for:
- showing folders for the initial resources from the unittest env
- creating resources, they should appear in the tree
- creating a search folder, should create "Search / search123456"
- deleting that search folder, both should disappear, and things
shouldn't get corrupted (kitemmodels bug, fix pending, test disabled
until KF 5.26)
The dummykernel from src/filter/tests is moved up to autotests/ for sharing.
David Faure
Daniel Vrátil