From c9f2d74b5bcf46e9fccc4cd451cd129e3b2462fe Mon Sep 17 00:00:00 2001 From: Volker Krause Date: Wed, 10 Aug 2016 09:05:01 +0200 Subject: [PATCH] Tag::compare arguments should be const references Besides being more correct, this fixes compilation errors with GCC 4.8 in KMail. --- src/tag/tag.cpp | 4 ++-- src/tag/tag.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/tag/tag.cpp b/src/tag/tag.cpp index 42f0199..f75c936 100644 --- a/src/tag/tag.cpp +++ b/src/tag/tag.cpp @@ -111,7 +111,7 @@ Akonadi::Tag Tag::saveToAkonadi(Tag::SaveFlags saveFlags) const return tag; } -bool Tag::compare(Tag::Ptr &tag1, Tag::Ptr &tag2) +bool Tag::compare(const Tag::Ptr &tag1, const Tag::Ptr &tag2) { if (tag1->priority < tag2->priority) { return true; @@ -122,7 +122,7 @@ bool Tag::compare(Tag::Ptr &tag1, Tag::Ptr &tag2) } } -bool Tag::compareName(Tag::Ptr &tag1, Tag::Ptr &tag2) +bool Tag::compareName(const Tag::Ptr &tag1, const Tag::Ptr &tag2) { return (tag1->tagName < tag2->tagName); } diff --git a/src/tag/tag.h b/src/tag/tag.h index 24a2370..3166eb1 100644 --- a/src/tag/tag.h +++ b/src/tag/tag.h @@ -59,9 +59,9 @@ public: Akonadi::Tag saveToAkonadi(SaveFlags saveFlags = SaveFlags(TextColor | BackgroundColor | Font)) const; // Compare, based on priority - static bool compare(Ptr &tag1, Ptr &tag2); + static bool compare(const Ptr &tag1, const Ptr &tag2); // Compare, based on name - static bool compareName(Ptr &tag1, Ptr &tag2); + static bool compareName(const Ptr &tag1, const Ptr &tag2); qint64 id() const; QString name() const;