From 0cc716d035cded99d579a22aa4821ccab49f2c2c Mon Sep 17 00:00:00 2001 From: Montel Laurent Date: Wed, 6 Sep 2017 13:23:44 +0200 Subject: [PATCH] Assign parent directly. Remove setLayout(...) when not necessary --- src/filter/filteractions/filteractionwidget.cpp | 3 +-- src/filter/tests/filterimporterexportergui.cpp | 3 +-- src/folder/folderselectiondialog.cpp | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/filter/filteractions/filteractionwidget.cpp b/src/filter/filteractions/filteractionwidget.cpp index 049b682..ba5afb5 100644 --- a/src/filter/filteractions/filteractionwidget.cpp +++ b/src/filter/filteractions/filteractionwidget.cpp @@ -109,9 +109,8 @@ FilterActionWidget::FilterActionWidget(QWidget *parent) : QWidget(parent) , d(new Private(this)) { - QHBoxLayout *mainLayout = new QHBoxLayout; + QHBoxLayout *mainLayout = new QHBoxLayout(this); mainLayout->setMargin(0); - setLayout(mainLayout); QWidget *widget = new QWidget(this); mainLayout->addWidget(widget); diff --git a/src/filter/tests/filterimporterexportergui.cpp b/src/filter/tests/filterimporterexportergui.cpp index f18ce68..95fc313 100644 --- a/src/filter/tests/filterimporterexportergui.cpp +++ b/src/filter/tests/filterimporterexportergui.cpp @@ -29,8 +29,7 @@ Q_DECLARE_METATYPE(MailCommon::FilterImporterExporter::FilterType) FilterImporterExporterGui::FilterImporterExporterGui(QWidget *parent) : QWidget(parent) { - QVBoxLayout *mainLayout = new QVBoxLayout; - setLayout(mainLayout); + QVBoxLayout *mainLayout = new QVBoxLayout(this); QMenuBar *menuBar = new QMenuBar(this); mainLayout->addWidget(menuBar); QMenu *menuFilter = menuBar->addMenu(QStringLiteral("filter")); diff --git a/src/folder/folderselectiondialog.cpp b/src/folder/folderselectiondialog.cpp index 4c0f3b9..0e26f14 100644 --- a/src/folder/folderselectiondialog.cpp +++ b/src/folder/folderselectiondialog.cpp @@ -68,8 +68,7 @@ FolderSelectionDialog::FolderSelectionDialog(QWidget *parent, SelectionFolderOpt d->mNotAllowToCreateNewFolder = (options & FolderSelectionDialog::NotAllowToCreateNewFolder); QDialogButtonBox *buttonBox = new QDialogButtonBox(QDialogButtonBox::Ok | QDialogButtonBox::Cancel, this); - QVBoxLayout *mainLayout = new QVBoxLayout; - setLayout(mainLayout); + QVBoxLayout *mainLayout = new QVBoxLayout(this); d->mOkButton = buttonBox->button(QDialogButtonBox::Ok); d->mOkButton->setDefault(true); d->mOkButton->setAutoDefault(true);