kwin/tabbox at 2c3bbb9783be79d47f20f601f6a4891dffc1e36c - kwin

History

Martin Gräßlin e9d20b80e9 [tabbox] Intercept QWheelEvents on QQuickWindow for scrolling Summary: The TabBox performs the scrolling of the items by itself in order to support wheel events even if the mouse is not on the TabBox. For that KWin grabs pointer events on X11 (on Wayland an input filter is used) and forwards them to the TabBox. Qt uses Xinput2 for scrolling on the QQuickWindow. Due to that KWin does not get any xcb core button press/release events when scrolling inside the QQuickWindow and thus scrolling doesn't work. There are three possible approaches to fix this: 1. Implement scrolling support in each of the QML switchers 2. Add an xinput2 filter to TabBox 3. Intercept the QWheelEvents on the QQuickWindow The first approach has the disadvantage that all themes need adjustment and that there might be behaviorial difference whether one scrolls on the TabBox window or outside the window. The second approach would be most in line with the other filters, but is difficult due to the nature of xinput2 (no xcb bindings, etc). Thus the third approach might be the best solution. Wheel events are only delivered to the QQuickWindow if the native events were not already intercepted, thus we know it won't have side effects for the case that Wayland is used or xinput2 is not supported. The implementation installs an event filter on the QQuickWindow which gets created when showing the TabBox and inside the filter waits till there is an angleDelta of +/-120 and scrolls by one per every 120 angle delta as described in the QWheelEvent documentation. BUG: 369661 FIXED-IN: 5.8.2 Test Plan: Scrolled with touchpad and mouse wheel. Reviewers: #kwin, #plasma, broulik Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D2953		10 years ago
..
CMakeLists.txt	Move tabbox/autotests to autotests/tabbox	10 years ago
clientmodel.cpp	…
clientmodel.h	…
desktopchain.cpp	Fix comparison between signed and unsigned integer expressions warning	12 years ago
desktopchain.h	…
desktopmodel.cpp	…
desktopmodel.h	…
kwindesktopswitcher.desktop	SVN_SILENT made messages (.desktop file) - always resolve ours	10 years ago
kwinwindowswitcher.desktop	SVN_SILENT made messages (.desktop file) - always resolve ours	10 years ago
switcheritem.cpp	update SwitcherItem::screenGeometry when showing	11 years ago
switcheritem.h	…
tabbox.cpp	[wayland] Fix release of TabBox on Wayland	10 years ago
tabbox.h	[wayland] Fix release of TabBox on Wayland	10 years ago
tabbox_logging.cpp	pedantic fixes	10 years ago
tabbox_logging.h	[tabbox] Add dedicated logging category for TabBox	11 years ago
tabboxconfig.cpp	…
tabboxconfig.h	[tabbox] Try locating the WindowSwitcher QML through configured lnf package	12 years ago
tabboxhandler.cpp	[tabbox] Intercept QWheelEvents on QQuickWindow for scrolling	10 years ago
tabboxhandler.h	[tabbox] Intercept QWheelEvents on QQuickWindow for scrolling	10 years ago