wilderjds/kwin - kwin - gitea-jacopods

16754 Commits

36 Branches

0 Tags

96 MiB

Tag: Branch: Tree: a2e36f714c

Commit Graph

Author	SHA1	Message	Date
Vlad Zagorodniy	78ce54f88a	[effects] Make scripted effects GHNS-able Summary: Currently, if one wants to install a scripted effect from the KDE Store, the effect won't show up in the Desktop Effects KCM. The reason for that is kpackagetool5 doesn't know where to install effects (they have to be installed under ${DATA_DIR}/kwin/effects). Another problem is that even if the scripted effect is installed in the right directory (e.g. ~/.local/share/kwin/effects), it won't be listed in the Desktop Effects KCM because it doesn't have a desktop file in kservices5 dir. Please notice that the effect will be "visible" for KWin, i.e. you can enable it by editing kwinrc. This diff addresses those 2 problems by: * Adding a PackageStructure plugin for effects (so they are installed under kwin/effects/); * Using KPackage::PackageLoader to get list of scripted effect in the Desktop Effects KCM. Test Plan: * Installed an effect from the KDE Store, it appeared in the Desktop Effects KCM; * Removed it. Reviewers: #kwin, mart, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: ngraham, davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D15372	8 years ago
Marco Martin	405518c41d	use proper packagestructures Summary: as the plasmapkg2 utility is dead, scripts and tabboxes couldn't be installed anymore, as plasmapkg2 was launched with an hardcoded package type (and had a bunch of custom code for it) and no packagestructure for the relevant package types existed. the port of scripts and tabboxes to kpackage in kwin is quite incomplete and somewhat strange (given the fact that was started by looking manually for the file as it couldn't link to libplasma) this makes things a bit better as now scripts and tabboxes have an actual package structure, making it installable by kpackagetool5. in the future, the port should be completed and replace all the manual lookup of files with package::filePath as it should work now given that valid structures exist BUG:374766 Test Plan: tabbox plugins and kwin scripts can be installed from knewstuff again and can be successfully loaded Reviewers: #plasma, graesslin, subdiff Reviewed By: #plasma, graesslin Subscribers: graesslin, plasma-devel, kwin, #kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D4202	9 years ago

Author

SHA1

Message

Date

Vlad Zagorodniy

78ce54f88a

[effects] Make scripted effects GHNS-able

Summary:
Currently, if one wants to install a scripted effect from the KDE Store,
the effect won't show up in the Desktop Effects KCM. The reason for that
is kpackagetool5 doesn't know where to install effects (they have to be
installed under ${DATA_DIR}/kwin/effects).

Another problem is that even if the scripted effect is installed in the
right directory (e.g. ~/.local/share/kwin/effects), it won't be listed in
the Desktop Effects KCM because it doesn't have a desktop file in
kservices5 dir. Please notice that the effect will be "visible" for KWin, i.e.
you can enable it by editing kwinrc.

This diff addresses those 2 problems by:
* Adding a PackageStructure plugin for effects (so they are installed
  under kwin/effects/);
* Using KPackage::PackageLoader to get list of scripted effect in the
  Desktop Effects KCM.

Test Plan:
* Installed an effect from the KDE Store, it appeared in the Desktop Effects
  KCM;
* Removed it.

Reviewers: #kwin, mart, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: ngraham, davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D15372

8 years ago

Marco Martin

405518c41d

use proper packagestructures

Summary:
as the plasmapkg2 utility is dead, scripts and tabboxes couldn't
be installed anymore, as plasmapkg2 was launched with an hardcoded
package type (and had a bunch of custom code for it)
and no packagestructure for the relevant package types existed.

the port of scripts and tabboxes to kpackage in kwin is quite
incomplete and somewhat strange (given the fact that was started by
looking manually for the file as it couldn't link to libplasma)

this makes things a bit better as now scripts and tabboxes have an actual
package structure, making it installable by kpackagetool5.
in the future, the port should be completed and replace all the manual lookup
of files with package::filePath as it should work now given that valid
structures exist

BUG:374766

Test Plan:
tabbox plugins and kwin scripts can be installed from knewstuff
again and can be successfully loaded

Reviewers: #plasma, graesslin, subdiff

Reviewed By: #plasma, graesslin

Subscribers: graesslin, plasma-devel, kwin, #kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D4202

9 years ago

1 Commits (a2e36f714c75401e1e1adf26b7bc6be88b300069)