wilderjds/kwin - kwin - gitea-jacopods

11025 Commits

36 Branches

0 Tags

96 MiB

Tag: Branch: Tree: 85ea66f736

Commit Graph

Author	SHA1	Message	Date
Martin Gräßlin	0fb27fd12e	Defines to create the boilerplate code for KWin's singleton classes The define KWIN_SINGLETON adds to a class definition: public: static Foo create(QObject parent = 0); static Foo self() { return s_self; } protected: explicit Foo(QObject parent = 0); private: static Foo s_self; There is an additional define KWIN_SINGLETON_VARIABLE to set a different name than s_self. The define KWIN_SINGLETON_FACTORY can be used to generate the create method. It expands to: Foo Foo::s_self = 0; Foo Foo::create(QObject parent) { Q_ASSERT(!s_self); s_self = new Foo(parent); return s_self; } In addition there are defines to again set a different variable name and to create an object of another inheriting class. All the classes currently using this pattern are adjusted to use these new defines. In a few places the name was adjusted. E.g. in Compositor the factory method was called createCompositor instead of create. REVIEW: 109865	13 years ago
Martin Gräßlin	7e3809a3ca	Split out Application Menu related code into own class Following the approach to move out of Workspace what doesn't belong into Workspace Appmenu support goes into an own class. This also has the advantage of better compilation with Qt 5 as moc seems to dislike ifdefs in the slot definitions. REVIEW: 109497	13 years ago

Author

SHA1

Message

Date

Martin Gräßlin

0fb27fd12e

Defines to create the boilerplate code for KWin's singleton classes

The define KWIN_SINGLETON adds to a class definition:

public:
    static Foo *create(QObject *parent = 0);
    static Foo *self() { return s_self; }
protected:
    explicit Foo(QObject *parent = 0);
private:
    static Foo *s_self;

There is an additional define KWIN_SINGLETON_VARIABLE to set a different
name than s_self.

The define KWIN_SINGLETON_FACTORY can be used to generate the create
method. It expands to:

Foo *Foo::s_self = 0;
Foo *Foo::create(QObject *parent)
{
    Q_ASSERT(!s_self);
    s_self = new Foo(parent);
    return s_self;
}

In addition there are defines to again set a different variable name and
to create an object of another inheriting class.

All the classes currently using this pattern are adjusted to use these
new defines. In a few places the name was adjusted. E.g. in Compositor
the factory method was called createCompositor instead of create.

REVIEW: 109865

13 years ago

Martin Gräßlin

7e3809a3ca

Split out Application Menu related code into own class

Following the approach to move out of Workspace what doesn't belong into
Workspace Appmenu support goes into an own class.

This also has the advantage of better compilation with Qt 5 as moc seems
to dislike ifdefs in the slot definitions.

REVIEW: 109497

13 years ago

2 Commits (85ea66f7365437afd322cd689a6acc5245dc19f5)