wilderjds/kwin - kwin - gitea-jacopods

Author	SHA1	Message	Date
David Edmundson	a3cff85e7a	Remove Qt module declarations in includes Summary: Test Plan: Compiles Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D13359	8 years ago
David Edmundson	5bca058826	Fix DRM EGL crash regression Summary: In `47343fb` we made GBM buffer shared. What we wanted to do was: Unbox the shared_pointer<GBMSurface> to give us a GBMSurface* object Call the gbm_surface() on that operator Then cast that to a void for eglCreatePlatformWindowSurfaceEXT What we did: Cast the std::shared_ptr<GBMSurface> to a gbm_surface* then cast that to void*. This is just a garbage value and it crashes in Mesa when we do our first paint. I've replaced that with an explicit method then we can use shared_ptr's -> operator rather than get() which does the right thing in a readable way. Test Plan: It crashed after rebasing to master (for Aleix too) No longer crashes Reviewers: #plasma Subscribers: plasma-devel, kwin, #kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8251	9 years ago
David Edmundson	3d619c995b	Fix DRM EGL crash regression Summary: In `47343fb` we made GBM buffer shared. What we wanted to do was: Unbox the shared_pointer<GBMSurface> to give us a GBMSurface* object Call the gbm_surface() on that operator Then cast that to a void for eglCreatePlatformWindowSurfaceEXT What we did: Cast the std::shared_ptr<GBMSurface> to a gbm_surface* then cast that to void*. This is just a garbage value and it crashes in Mesa when we do our first paint. I've replaced that with an explicit method then we can use shared_ptr's -> operator rather than get() which does the right thing in a readable way. Test Plan: It crashed after rebasing to master (for Aleix too) No longer crashes Reviewers: #plasma Subscribers: plasma-devel, kwin, #kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8251	9 years ago
Martin Flöser	47343fb8f7	[platforms/drm] Use a shared pointer for gbm_surface Summary: The gbm_surface is owned by the EglGbmBackend, but it's not the only one using it. The DrmSurfaceBuffer is also using it and needs it to destroy the gbm_bo. Now this can become a problem in the following situation: * a page flip is still pending * the EglGbmBackend destroys the gbm_surface -> when the page flip happens the DrmSurfaceBuffer will try to destroy the gbm_bo and crash as the gbm_surface is no longer valid. This situation can happen when switching screens or when switching compositing backend (OpenGL 2 -> OpenGL 3). To address this problem a class GbmSurface is added which wrapps the gbm_surface pointer. The EglGbmBackend creates and holds a shared pointer to the GbmSurface and passes that one to the DrmSurfaceBuffer. So when cleaning up the gbm_surface only the shared pointer is reset and in case the DrmSurfaceBuffer still needs it, it can access it without problems. BUG: 385372 FIXED-IN: 5.11.0 Test Plan: Not yet Reviewers: #kwin, #plasma, subdiff Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8152	9 years ago