wilderjds/kwin - kwin - gitea-jacopods

10476 Commits

36 Branches

0 Tags

96 MiB

Tag: Branch: Tree: 5afe5f810e

Commit Graph

Author	SHA1	Message	Date
Martin Gräßlin	b6681ddc3a	Turn RootInfo into a KWIN_SINGLETON It's not a typical singleton as the ctor is not taking a Workspace* and needs addtional data to be passed to NETRootInfo. All the initialization code is moved to RootInfo::create() and the tear- down code is moved to RootInfo::destroyed(). This includes the support window which used to be a member of Workspace. It's only needed by RootInfo, so there is no need to have the ownership inside Workspace. Instead of using a QWidget we just create a normal window through xcb. It gets destroyed again in the tear-down code after the RootInfo got destroyed. REVIEW: 110238	13 years ago
Martin Gräßlin	db18c08dd0	Move RootInfo and WinInfo into an own header and impl file Main motivation for this change is that it's unhandy to have the class definition in workspace.h and client.h while the implementation is in events.cpp although nothing in events.cpp uses it directly. By getting it out of workspace.h we get the header a little bit smaller which should improve compile time given that it's included almost everywhere. In events.cpp the enum usage is changed to NETWinInfo as that's the class where they are defined. RootInfo does no longer hold a workspace pointer. Where it's needed it uses the singleton accessor of Workspace. REVIEW: 110199	13 years ago

Author

SHA1

Message

Date

Martin Gräßlin

b6681ddc3a

Turn RootInfo into a KWIN_SINGLETON

It's not a typical singleton as the ctor is not taking a Workspace* and
needs addtional data to be passed to NETRootInfo.

All the initialization code is moved to RootInfo::create() and the tear-
down code is moved to RootInfo::destroyed(). This includes the support
window which used to be a member of Workspace. It's only needed by
RootInfo, so there is no need to have the ownership inside Workspace.

Instead of using a QWidget we just create a normal window through xcb.
It gets destroyed again in the tear-down code after the RootInfo got
destroyed.

REVIEW: 110238

13 years ago

Martin Gräßlin

db18c08dd0

Move RootInfo and WinInfo into an own header and impl file

Main motivation for this change is that it's unhandy to have the class
definition in workspace.h and client.h while the implementation is in
events.cpp although nothing in events.cpp uses it directly.

By getting it out of workspace.h we get the header a little bit smaller
which should improve compile time given that it's included almost
everywhere.

In events.cpp the enum usage is changed to NETWinInfo as that's the class
where they are defined.

RootInfo does no longer hold a workspace pointer. Where it's needed it
uses the singleton accessor of Workspace.

REVIEW: 110199

13 years ago

2 Commits (5afe5f810e2a76dc6fff4088746f2728c8a6a93d)