launcher: Fix a file descriptor leak

The file descriptor must be closed after sending a ReleaseDevice request.
6 years ago · dbf52ebda5
parent f369a3557c
commit dbf52ebda5
1 changed files with 8 additions and 7 deletions
--- a/logind.cpp
+++ b/logind.cpp
@ -378,14 +378,15 @@ void LogindIntegration::releaseDevice(int fd)
    struct stat st;
    if (fstat(fd, &st) < 0) {
        qCDebug(KWIN_CORE) << "Could not stat the file descriptor";
-        return;
+    } else {
+        QDBusMessage message = QDBusMessage::createMethodCall(m_sessionControllerService,
+                                                              m_sessionPath,
+                                                              m_sessionControllerSessionInterface,
+                                                              QStringLiteral("ReleaseDevice"));
+        message.setArguments(QVariantList({QVariant(major(st.st_rdev)), QVariant(minor(st.st_rdev))}));
+        m_bus.asyncCall(message);
    }
-    QDBusMessage message = QDBusMessage::createMethodCall(m_sessionControllerService,
-                                                          m_sessionPath,
-                                                          m_sessionControllerSessionInterface,
-                                                          QStringLiteral("ReleaseDevice"));
-    message.setArguments(QVariantList({QVariant(major(st.st_rdev)), QVariant(minor(st.st_rdev))}));
-    m_bus.asyncCall(message);
+    close(fd);
 }

 void LogindIntegration::pauseDevice(uint devMajor, uint devMinor, const QString &type)