The effect does not work very well for two main reasons: Some clients will make a new popup rather than move an existing one, so whether it does anything is highly unpredictable as a user. Popups can be of massively different sizes with different amounts of text. This means the text in the smaller popup gets resized which doesn't look like a natural in-between state of the two popups. This defeats the objective of looking smoother. On top of that, it's rather glitchy. This effect was purely visual, no functionality changes. BUG: 473411 BUG: 466638 BUG: 416048 BUG: 461501 BUG: 466637wilder/Plasma/6.2
David Edmundson
2 years ago
parent
64b02cf464
commit
d6360cc4ce
4 changed files with 0 additions and 283 deletions
@ -1 +0,0 @@ |
||||
kwin_add_scripted_effect(morphingpopups package) |
||||
@ -1,137 +0,0 @@ |
||||
/* |
||||
This file is part of the KDE project. |
||||
|
||||
SPDX-FileCopyrightText: 2012 Martin Gräßlin <mgraesslin@kde.org> |
||||
SPDX-FileCopyrightText: 2016 Marco Martin <mart@kde.org> |
||||
|
||||
SPDX-License-Identifier: GPL-2.0-or-later |
||||
*/ |
||||
|
||||
"use strict"; |
||||
|
||||
var morphingEffect = { |
||||
duration: animationTime(150), |
||||
loadConfig: function () { |
||||
morphingEffect.duration = animationTime(150); |
||||
}, |
||||
|
||||
handleFrameGeometryAboutToChange: function (window) { |
||||
var couldRetarget = false; |
||||
if (window.fadeAnimation) { |
||||
couldRetarget = retarget(window.fadeAnimation[0], 1.0, morphingEffect.duration); |
||||
} |
||||
|
||||
if (!couldRetarget) { |
||||
window.fadeAnimation = animate({ |
||||
window: window, |
||||
duration: morphingEffect.duration, |
||||
curve: QEasingCurve.InOutCubic, |
||||
animations: [{ |
||||
type: Effect.CrossFadePrevious, |
||||
to: 1.0, |
||||
from: 0.0 |
||||
}] |
||||
}); |
||||
} |
||||
}, |
||||
handleFrameGeometryChanged: function (window, oldGeometry) { |
||||
var newGeometry = window.geometry; |
||||
|
||||
//only do the transition for near enough tooltips,
|
||||
//don't cross the whole screen: ugly
|
||||
var distance = Math.abs(oldGeometry.x - newGeometry.x) + Math.abs(oldGeometry.y - newGeometry.y); |
||||
|
||||
if (distance > (newGeometry.width + newGeometry.height) * 2) { |
||||
if (window.moveAnimation) { |
||||
delete window.moveAnimation; |
||||
} |
||||
if (window.fadeAnimation) { |
||||
delete window.fadeAnimation; |
||||
} |
||||
|
||||
return; |
||||
} |
||||
|
||||
//don't resize it "too much", set as four times
|
||||
if ((newGeometry.width / oldGeometry.width) > 4 || |
||||
(oldGeometry.width / newGeometry.width) > 4 || |
||||
(newGeometry.height / oldGeometry.height) > 4 || |
||||
(oldGeometry.height / newGeometry.height) > 4) { |
||||
return; |
||||
} |
||||
|
||||
window.setData(Effect.WindowForceBackgroundContrastRole, true); |
||||
window.setData(Effect.WindowForceBlurRole, true); |
||||
|
||||
var couldRetarget = false; |
||||
|
||||
if (window.moveAnimation) { |
||||
if (window.moveAnimation[0]) { |
||||
couldRetarget = retarget(window.moveAnimation[0], { |
||||
value1: newGeometry.width, |
||||
value2: newGeometry.height |
||||
}, morphingEffect.duration); |
||||
} |
||||
if (couldRetarget && window.moveAnimation[1]) { |
||||
couldRetarget = retarget(window.moveAnimation[1], { |
||||
value1: newGeometry.x + newGeometry.width/2, |
||||
value2: newGeometry.y + newGeometry.height / 2 |
||||
}, morphingEffect.duration); |
||||
} |
||||
if (!couldRetarget) { |
||||
cancel(window.moveAnimation[0]); |
||||
} |
||||
|
||||
} |
||||
|
||||
if (!couldRetarget) { |
||||
window.moveAnimation = animate({ |
||||
window: window, |
||||
duration: morphingEffect.duration, |
||||
curve: QEasingCurve.InOutCubic, |
||||
animations: [{ |
||||
type: Effect.Size, |
||||
to: { |
||||
value1: newGeometry.width, |
||||
value2: newGeometry.height |
||||
}, |
||||
from: { |
||||
value1: oldGeometry.width, |
||||
value2: oldGeometry.height |
||||
} |
||||
}, { |
||||
type: Effect.Position, |
||||
to: { |
||||
value1: newGeometry.x + newGeometry.width / 2, |
||||
value2: newGeometry.y + newGeometry.height / 2 |
||||
}, |
||||
from: { |
||||
value1: oldGeometry.x + oldGeometry.width / 2, |
||||
value2: oldGeometry.y + oldGeometry.height / 2 |
||||
} |
||||
}] |
||||
}); |
||||
|
||||
} |
||||
}, |
||||
|
||||
manage: function (window) { |
||||
//only tooltips and notifications
|
||||
if (!window.tooltip && !window.notification && !window.criticalNotification) { |
||||
return; |
||||
} |
||||
|
||||
window.windowFrameGeometryAboutToChange.connect(morphingEffect.handleFrameGeometryAboutToChange); |
||||
window.windowFrameGeometryChanged.connect(morphingEffect.handleFrameGeometryChanged); |
||||
}, |
||||
|
||||
init: function () { |
||||
effect.configChanged.connect(morphingEffect.loadConfig); |
||||
effects.windowAdded.connect(morphingEffect.manage); |
||||
|
||||
for (const window of effects.stackingOrder) { |
||||
morphingEffect.manage(window); |
||||
} |
||||
} |
||||
}; |
||||
morphingEffect.init(); |
||||
Loading…
Reference in new issue