From 68015321e924e1dd54770df748cd42440aaf204f Mon Sep 17 00:00:00 2001 From: Xaver Hugl Date: Tue, 1 Oct 2024 17:36:08 +0200 Subject: [PATCH] window: prevent infinite recursion in setQuickTileMode If there's a window rule, setMaximize may not actually change the maximize mode, so this needs to be accounted for BUG: 493778 --- src/window.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/window.cpp b/src/window.cpp index 94e4b8561a..ff1c90332e 100644 --- a/src/window.cpp +++ b/src/window.cpp @@ -3589,6 +3589,10 @@ void Window::setQuickTileMode(QuickTileMode mode, const QPointF &tileAtPoint) if (requestedMaximizeMode() != MaximizeRestore) { m_requestedQuickTileMode = QuickTileFlag::None; setMaximize(false, false); + if (requestedMaximizeMode() != MaximizeRestore) { + // window rules may enforce a different maximize mode, we can't do anything here + return; + } setQuickTileMode(mode, tileAtPoint); return; }