From 4aec002d139088f524962d8d2b431d91eef01000 Mon Sep 17 00:00:00 2001 From: Vlad Zahorodnii Date: Tue, 21 Mar 2023 09:52:47 +0200 Subject: [PATCH] effects: Make -DTRANSLATION_DOMAIN target specific This makes effect specific cmake code more encapsulated. It's also more readable if the translation domain is specified explicitly rather than having it implicitly set by add_definitions(). --- src/effects/CMakeLists.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/effects/CMakeLists.txt b/src/effects/CMakeLists.txt index a851042a72..e74cb3f8d2 100644 --- a/src/effects/CMakeLists.txt +++ b/src/effects/CMakeLists.txt @@ -1,12 +1,10 @@ -# KI18N Translation Domain for this library -add_definitions(-DTRANSLATION_DOMAIN=\"kwin_effects\" -DEFFECT_BUILTINS) - add_subdirectory(private) function(kwin_add_effect_config name) list(REMOVE_ITEM ARGV ${name}) kcoreaddons_add_plugin(${name} INSTALL_NAMESPACE "kwin/effects/configs" SOURCES ${ARGV}) + target_compile_definitions(${name} PRIVATE -DTRANSLATION_DOMAIN=\"kwin_effects\") endfunction() # Add a CMake-time check for python3 to avoid failures during build. @@ -30,6 +28,7 @@ endfunction() macro(kwin_add_builtin_effect name) kcoreaddons_add_plugin(${name} STATIC SOURCES ${ARGN} INSTALL_NAMESPACE "kwin/effects/plugins") + target_compile_definitions(${name} PRIVATE -DTRANSLATION_DOMAIN=\"kwin_effects\") set_property(TARGET ${name} PROPERTY POSITION_INDEPENDENT_CODE ON) kwin_strip_builtin_effect_metadata(${name} metadata.json) install(FILES metadata.json DESTINATION ${KDE_INSTALL_DATADIR}/kwin/builtin-effects/ RENAME ${name}.json)