From 1c3a987d7436edf746ca64557f8d5cc553ffe719 Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Mon, 3 Jun 2024 08:36:53 +0000 Subject: [PATCH] wayland: Only load HiddenPreviews options in X11 HiddenPreviews was a hack to not inform X11 that windows were minimised, so that their previews kept working. On wayland the user facing setting is not visible but the value is loaded which is a bad combination. CCBUG: 415286 --- src/options.cpp | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/src/options.cpp b/src/options.cpp index 4a3fd2e4c6..d7a240f255 100644 --- a/src/options.cpp +++ b/src/options.cpp @@ -787,17 +787,19 @@ void Options::loadConfig() } setGlPreferBufferSwap(c); - HiddenPreviews previews = Options::defaultHiddenPreviews(); - // 4 - off, 5 - shown, 6 - always, other are old values - int hps = config.readEntry("HiddenPreviews", 5); - if (hps == 4) { - previews = HiddenPreviewsNever; - } else if (hps == 5) { - previews = HiddenPreviewsShown; - } else if (hps == 6) { - previews = HiddenPreviewsAlways; - } - setHiddenPreviews(previews); + if (kwinApp()->operationMode() == Application::OperationModeX11) { + HiddenPreviews previews = Options::defaultHiddenPreviews(); + // 4 - off, 5 - shown, 6 - always, other are old values + int hps = config.readEntry("HiddenPreviews", 5); + if (hps == 4) { + previews = HiddenPreviewsNever; + } else if (hps == 5) { + previews = HiddenPreviewsShown; + } else if (hps == 6) { + previews = HiddenPreviewsAlways; + } + setHiddenPreviews(previews); + } auto interfaceToKey = [](OpenGLPlatformInterface interface) { switch (interface) {