Thanks to Ahmad Samir ahmadsamir3891 gmail com for patch.
Todo: any changes to the settings should auto proprogate to all tabs'
search bars.
Review: 129376
Feature: 332601
getProcessInfo() returned _foregroundProcessInfo without checking the
return value of updateForegroundProcessInfo() indicating whether
_foregroundProcessInfo was non-existent or invalid.
I think this might be the solution to a bunch of recent crash bugs,
but not closing them as I can't test.
Also skipping RB because it is a simple patch and RB is down from here.
CCBUG: 372401
CCBUG: 372620
CCBUG: 372619
CCBUG: 372593
(cherry picked from commit 40b1f0e851)
getProcessInfo() returned _foregroundProcessInfo without checking the
return value of updateForegroundProcessInfo() indicating whether
_foregroundProcessInfo was non-existent or invalid.
I think this might be the solution to a bunch of recent crash bugs,
but not closing them as I can't test.
Also skipping RB because it is a simple patch and RB is down from here.
CCBUG: 372401
CCBUG: 372620
CCBUG: 372619
CCBUG: 372593
Use the new std::random APIs in c++11 for generating random numbers,
which is much safer and doesn't abuse qsrand().
This also means we don't need to copy in the QUuid::createUuid() code
anymore, which generated a warning in ubsan.
REVIEW: 129342
Recent code changed how %u is handled (only when %u is required, poll
/proc filesystem). This correct an issue when %u is added/removed from
the Rename Tab dialog.
Update the tab title to current program running.
Martin, this "if" was committed in
79ca76a946. For now, I removed the "if"
CCBUG: 368785
(cherry picked from commit 3747ecfde0)
The only processes that are "safe" or require us to send an EOF to
terminate cleanly are shells, so verify that people didn't run with -e
tmux or similar.
REVIEW: 128791
BUG: 367746
(cherry picked from commit ce4ab92249)
The old method of checking it has unnecessary overhead (doing a full
process info update), and wasn't very reliable.
Instead just get the original shell PID from QProcess (via KProcess),
and the foreground process from the PTY.
CCBUG: 367746
REVIEW: 128789
(cherry picked from commit 79ca76a946)
The only processes that are "safe" or require us to send an EOF to
terminate cleanly are shells, so verify that people didn't run with -e
tmux or similar.
REVIEW: 128791
BUG: 367746
The old method of checking it has unnecessary overhead (doing a full
process info update), and wasn't very reliable.
Instead just get the original shell PID from QProcess (via KProcess),
and the foreground process from the PTY.
CCBUG: 367746
REVIEW: 128789
According to the bash maintainer sending EOF is the appropriate way of
telling e. g. bash to quit:
http://permalink.gmane.org/gmane.comp.shells.bash.bugs/12602
I wasn't able to get KPtyProcess to send that in a nice way (calling
setStandardInputFile(QProcess::nullDevice(), for example), so we fetch
the EOF character manually with tcgetattr and send that.
BUG: 185140
REVIEW: 128416
Implements support for the OSC 7 "standard" for tracking open
directories in the terminal (e. g. for bookmarks).
From the bug report, this is apparently what the osx terminal, iterm and
gnome terminal uses to keep track of stuff. I kept the existing tracking
as a fallback.
REVIEW: 128351
BUG: 336618
readUserName() reads /etc/passwd every few seconds. Change it to only
do this if we need to replace %u with the user name in the tab title.
A temporary helper as this doesn't really fix the underlining issue.
ProcessInfo really needs re-worked.
CCBUG: 325442
There are some security concerns about allowing sendText and runCommand
to be on the public D-Bus. Now, once upon a Konsole startup, a
notification will popup noting this concern when either of these two
methods are called. There is a cmake definition that will remove
these methods from the public D-Bus.
Discussion on the KDE security mailing list.
Instead of using a hardcoded delay and hope that the signals are handled
in the right order just use a direct connection for the first signal so
we can guarantee that it is handled before the execution continues to
the emission of the second signal.
REVIEW: 127724
vim uses control sequence 'echo -e "\033]11;?\a"' to request real
background color -- to detect whether terminal has dark or light
background.
Thanks to Pavel Raiskup praiskup redhat com
REVIEW: 125333
BUG: 352945
FIXED-IN: 15.12
Do not check foreground process to determine if current directory has
changed. Fixes nasty bugs such as 'man ls' changes to man folder.
This changes the BIC so the patch is different than the one committed
in KDE 4.14.x
Thanks to Arjun AK arjunak234 gmail com
.REVIEW: 120763
.BUG: 305085
.FIXED-IN: 14.12
(cherry picked from commit f269c1ad5986784981ba9c49127df2bfdcdee8fe)
Kurt Hindenburg
Aleix Pol
Martin T. H. Sandsmark
David Faure
Montel Laurent
Michal Humpula