Summary:
In all the cases that were changed, the bounding rect is needed. A few
places were not ported, since they need more careful investigation.
This reduces deprecation warnings.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D23144
Summary:
* Use custom dialog and configuraton classes, as counterparts from KF5
are bugged. The KF5 versions should be fixed and used here.
* Create new KConfigDialog-like class and use it to show existing
configuration pages.
* Create KConfigDialogManager-like class for managing QButtonGroups.
* Remove help button from configuration dialog. There is nothing about
configuration dialog options in the help.
* Profile Settings:
* Use QTreeView instead of QTableView - it highlights whole lines,
aligns header names to the left, etc. Basically it looks like lists
in file manager or e.g. plugin list in Kate.
* Use (default) QStyledItemDelegate with checkbox instead of custom
delegate (tick mark) in favorite/show column.
* Change default profile item style - it now has italics font and
"(default)" suffix.
* Disable "Delete" button when default profile is selected
* Use slightly extended QKeySequenceEditor. KKeySequenceWidget looks
heavily out of place in a tree view. New editor supports some
control keys:
* Esc key cancels key capture.
* Del/backspace removes shortcut.
* Enter confirms shortcut immediately.
* Tab/backtab commits currently edited shorcut and moves to
next/previous shortcut.
* Shortcuts for non visible profiles use disabled text color.
* Note about visibility and shortcuts
* Rename "File Location" to "Temporary Files"
* Enable path selector only when "custom" is selected
* Place paths directly in labels
* Disable all tabbar settings except visibility when visibility is set
to "Never"
* Minor string changes.
**Screenshots**
{F6893460}
{F6893461}
{F6893462}
{F6893463}
BUG: 404096
FIXED-IN: 19.08.0
Reviewers: #konsole, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, hindenburg, #vdg, konsole-devel, #konsole
Tags: #konsole, #vdg
Differential Revision: https://phabricator.kde.org/D20816
Summary:
Favor manual list creator over for loop for small list
Three items, create them manually, cleaner and less
computationally expensive.
Btw - this is ugly, both ways. I blame QStandardItemModel.
Simplify Logic
Use auto when types are explicit
Simplify Logic: use ternary when it improves readability
Stack when heap's uneeded.
There's absolutely no point on creating a QPointer
and manually deleting the item later. Just create
the variable on the stack
Auto when type's explicit
Subscribers: konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D13532
- Double-clicking on name opens Edit Profile dialog
- Only allow renaming from the Edit Profile dialog
- Upon renaming of a profile, change shortcut to new profile name
- Upon renaming of a profile, delete old named profile file.
- Do not allow renaming of a profile if that name already exists.
Patch by ahmadsamir; I made a few changes (name/const).
Differential Revision: https://phabricator.kde.org/D9272
Change the stand alone ManageProfiles dialog into a tab inside the
Configure Konsole window.
Side effect is that Konsole KParts can't open manage profiles.
Kurt Hindenburg
Ahmad Samir
Konstantin Kharlamov
Frederik Gladhorn
Mariusz Glebocki
Laurent Montel
Tomaz Canabrava
Martin T. H. Sandsmark
Michal Humpula
Alex Richardson