Summary:
Allow to use scrolling (Shift+Up/Down/PgUp/PgDown/Home/End) and a key
for showing URL hints when the view is in read-only mode.
Test Plan:
* Prepare
* Turn on scrollback
* Set at least one modifier key for "Show URL hints" (edit profile → advanced)
* Generate a few screens of text in Konsole
* Display some URL (e.g. `echo 'www.kde.org'`)
* Display current time every second: `while sleep 1; do printf '\r%s' "$(date)"; done`
* Turn on read-only mode
* Patch tests
* Hold down URL hint key - the URL should be underlined with square and a digit on the left
* Press <URL-hint-key>+1 - the URL should open in a web browser
* Scroll the view with Shift+Up/Down/PgUp/PgDown/Home/End - the view should scroll
* Split the view, do previous test in each split - only currently active split should scroll
* Regressions tests
* Press different keys (including Ctrl+C, Ctrl+Z, etc; skip those mapped to Konsole actions) - nothing in terminal should happen
* Press Ctrl+S - the time should not stop updating
* Use IME to enter text - nothing in terminal should be shown
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D11668
Summary:
Allow to use scrolling (Shift+Up/Down/PgUp/PgDown/Home/End) and a key
for showing URL hints when the view is in read-only mode.
Test Plan:
* Prepare
* Turn on scrollback
* Set at least one modifier key for "Show URL hints" (edit profile → advanced)
* Generate a few screens of text in Konsole
* Display some URL (e.g. `echo 'www.kde.org'`)
* Display current time every second: `while sleep 1; do printf '\r%s' "$(date)"; done`
* Turn on read-only mode
* Patch tests
* Scroll the view with Shift+Up/Down/PgUp/PgDown/Home/End - the view should scroll
* Hold down URL hint key - the URL should be underlined with square and a digit on the left
* Press <URL-hint-key>+1 - the URL should open in a web browser
* Regressions tests
* Press different keys (including Ctrl+C, Ctrl+Z, etc; skip those mapped to Konsole actions) - nothing in terminal should happen
* Press Ctrl+S - the time should not stop updating
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D11668
Summary:
This patch addresses the following points:
- Ignore most DBus methods
- Disable the following actions:
clear-history, clear-history-and-reset, edit-current-profile, switch-profile
adjust-history, send-signal, zmodem-upload, edit-rename (tab bar)
- Session updates all views correctly when readonly changes
{F5754353}
Test Plan:
- Actions do not show when locked
- DBus methods are ignored when locked
- Multiple views in one session get correctly updated
Reviewers: hindenburg, #konsole
Reviewed By: hindenburg, #konsole
Subscribers: ngraham, hindenburg, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D11341
Summary:
When applying profile changes don't touch tab titles explicilty set by
the user (via the rename tab dialog); the same goes when previewing
color schemes.
Update the tab text only if the user actually changed the the tab title
fomart in the rename tab dialog.
BUG: 354403
FIXED-IN: 18.04
Test Plan:
- In a konsole window with 2 or more tabs, rename a tab using the
rename-tab dialog
- Open the Edit Profile dialog and change some settings and save, also
try previewing some color schemes; note that the tab title changes
are kept
- In the Edit Profile dialog, change the tab format on the Tabs page,
and apply; note that the tab title the was renamed by the user isn't
changed but the tab(s) whose name wasn't changed are affected by the
tab title format setting change
- Open the rename-tab dialog, don't change anything and click OK; now
konsole doesn't count that as a tab title change
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D11363
Summary:
Konsole sends up/down key press events for mouse scrolls for apps that
aren't interested in mouse events, such as less. Only do this when the
terminal is using the alternate screen.
Now scrolling up/down will be translated to up/down key presses only
when the terminal is using the alternate screen but scrolling in a terminal
using the primary screen will only scroll using the scrollbar, now it does
not cycle through the shell history.
Now the behavior matches xterm and and gnome-terminal.
BUG: 355106
FIXED-IN: 18.04
Reviewers: hindenburg
Reviewed By: hindenburg
Subscribers: rkflx, ngraham, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D11146
Summary:
Depends on D10862
Before:
{F5734372}
After:
{F5734369}
Read-only:
{F5734370}
Both:
{F5734371}
This also fixes the overlapped scrollbar (see first screenshot).
Test Plan: Tested before and after, behaviour is the same.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: herrold, hindenburg, ngraham
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D10935
Summary:
This patch adds a read-only option for TerminalDisplays. When active,
all keyboard events are eaten. Mouse input is not affected and works like before.
The setting is not persisted and only lasts for the duration of the session.
Screenshots:
{F5730786}
{F5730788}
{F5730789}
VDG input is highly appreciated. Also, I'm not sure if I can just change the rc-files without bumping the version?
FEATURE: 126930
Test Plan:
- Shortcuts still work
- Paste and drop actions are disabled when readonly
- Switching between read-only and normal tabs works as expected
- Mouse input works like before
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, ngraham, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D10862
If the user presses e. g. arrow up, we should actually scroll down. What
I intended to fix was only the case where the user only pressed a
modifier.
And hardcoding a list of keys and behaviors is bad and bug prone, so I
think this is the best solution.
REVIEW: 128827
This should update filters less often, and also hopefully fix the issue
where underlined links get stuck while scrolling.
The idea is to not to do it on all mouse updates, only when needed on
mouse updates, and also not display the filters if they are out of date.
The only thing that should happen on screen changes now is setting the
_filterUpdateRequired variable to true, which leads to the filters not
being displayed until re-processed, which happens the next time the
mouse moves, unless I fucked something up.
REVIEW: 128393
(cherry picked from commit f3ce85b9ef)
This should update filters less often, and also hopefully fix the issue
where underlined links get stuck while scrolling.
The idea is to not to do it on all mouse updates, only when needed on
mouse updates, and also not display the filters if they are out of date.
The only thing that should happen on screen changes now is setting the
_filterUpdateRequired variable to true, which leads to the filters not
being displayed until re-processed, which happens the next time the
mouse moves, unless I fucked something up.
REVIEW: 128393
Port away from using QRegExp to QRegularExpression. The result is a bit
better performance, a bit more readable code (imho) and also no more
relying on mutable state in static objects (like in the keyboard
translator parser).
REVIEW: 128346
An updated version of the patch by Adam Treat <treat@kde.org>:
Implement a new file filter using POSIX Portable Filename Character
Set along with KDE's mimetype database of file extension blobs that
filters text matching a POSIX portable pathname and underlines it
very much like links.
REVIEW: 128241
REVIEW: 114376
vim uses control sequence 'echo -e "\033]11;?\a"' to request real
background color -- to detect whether terminal has dark or light
background.
Thanks to Pavel Raiskup praiskup redhat com
REVIEW: 125333
BUG: 352945
FIXED-IN: 15.12
Kurt Hindenburg
Mariusz Glebocki
Joshua Noack
Ahmad Samir
R.J.V. Bertin
Martin T. H. Sandsmark
Luigi Toscano
Alexander Potashev