ab75e68b11
Allow user to enter location to store Konsole's scrollback files
...
Add a third option which allows the user to enter any folder to store
the scrollback files.
BUG: 373664
Differential Revision: https://phabricator.kde.org/D5575
9 years ago
a540e6fdd0
Fix readability-implicit-bool-cast issues using nullptr
9 years ago
5648ec1a1a
Use QLatin1* to handle casts from ascii
9 years ago
869c361602
constructors/decontructors use =default instead of {}
9 years ago
dfafff97d4
remove QDebug/qWarning and use QCDebug
9 years ago
2b586e6ff8
use auto
9 years ago
5e28796d47
fix issue of readability-implicit-bool-cast
9 years ago
a4f5d539ff
initialize variable
9 years ago
3f651a51f5
remove extra ; and ,
9 years ago
c026b0e4b1
Fix potential out of bounds read.
...
The check was only done when not memory mapped, so there was a potential
out of bounds read. In addition the check only printed an error, and
didn't return and went ahead with the erronous read.
The 'loc' variable is indirectly read from the file, so in case the
history file is corrupted this could potentially lead to a crash.
Found by Coverity.
REVIEW: 128153
10 years ago
ee640027c3
Use a clearer config name when using ::CacheLocation for scrollback
...
s/scrollbackUseUsersHomeLocation/scrollbackUseCacheLocation/
11 years ago
a1957e8a8f
Allow user to select where the scrollback/history files are written.
...
Currently, when unlimited scrollback is used, the files are stored in
/tmp. As noted in the bug report, this can cause issues on some
distros. The default is still /tmp but the user can selected to use
a location in their $HOME folder (QStandardPaths::CacheLocation).
This is somewhat a WIP. Allowing for the changes to take effect
immediately appears to be a gigantic mess to get to work.
CCBUG: 173283
11 years ago
8b3a05d688
Store History in cache instead of tmp
...
Some distros have small /tmp and/or use tmpfs, and large history
(esp unlimited scrollback) can potentially fill disk or VM.
BUG: 173283
REVIEW: 123804
11 years ago
649e3654c8
Port KDE_lseek to QT_LSEEK
11 years ago
8182ac8edc
Port to QDebug
12 years ago
15d09f9161
port from KStandardDirs to QStandardPaths
...
REVIEW: 120498
12 years ago
cc24ae1ec3
Fix members not being initialized in constructor
...
(cherry picked from commit bda5e42729
12 years ago
bda5e42729
Fix members not being initialized in constructor
12 years ago
1587210d35
use the new temp call QDir::tempPath()
13 years ago
ab61a94a25
Remove Q_ASSERT - the HistoryTest crashes on the assert otherwise
...
(cherry picked from commit c6345e125e
13 years ago
c6345e125e
Remove Q_ASSERT - the HistoryTest crashes on the assert otherwise
13 years ago
c8a4fabde9
Use a return value instead of just Q_ASSERT - don't crash in production
...
(cherry picked from commit cb1536aaba
13 years ago
cb1536aaba
Use a return value instead of just Q_ASSERT - don't crash in production
13 years ago
cdf2b2bc78
Switch from c-style casting to c++ casting via static_cast
13 years ago
2f7608aca9
Rename member variables to follow the common naming style used in konsole
14 years ago
f77f78a71d
Use 0 inplace of NULL
14 years ago
f2151c5e29
Memory-based history should save and restore the 'isRealCharacter' field
...
Apparently I didn't take a close look at the implementation detail of
memory-based history when I added the 'isRealCharacter' flag. That
missing information causes some wrong behaviors randomly when using
memory-based history.
This is a follow up of commit dc2b64d33(for BUG 188528)
BUG: 294330
BUG: 299252
FIXED-IN: 4.8.4
14 years ago
bee9aa8f78
minor style fixes - remove empty lines start/end code blocks
14 years ago
5b083640ce
whitespace and style fixes
...
Use 'git diff -w --ignore-all-space' to see non-whitespace changes
14 years ago
e0862c603a
Style fixes - separte commands - remove 2 ; - align { elses
14 years ago
519e2614d6
Style fixes - remove spaces before ; and add spaces in for loops
14 years ago
25b8b5353c
Trivial style change: remove extra blank lines
14 years ago
7428abab6c
-Wshadow fixes to parameter names and variable names
14 years ago
90469a094a
Add more constness
14 years ago
26331fc17c
assert ==> Q_ASSERT
14 years ago
3b7e953523
Yet another around of cleaning up #includes
14 years ago
d087f9667a
Switch from using KTemporaryFile to using QTemporaryFile
...
Also change the temp file names so people know what they are.
konsole-XXXXXX.history
14 years ago
898d889890
Apply astyle-kdelibs a little more
...
Use 'diff -w --ignore-all-space' to see non-whitespace changes.
14 years ago
048160153a
Remove more unused code
14 years ago
5a5db5915b
Remove unused code
14 years ago
fa0459f9c6
Remove BlockArray and unused code dealing w/ History.
14 years ago
fe54ca3745
Apply astyle-kdelibs
...
Over the years, the coding style is all over the place.
Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
14 years ago
125e2c7bd2
Declare pointer and reference in a consistent way
...
Most code use the "const QString& text" form, instead of the "const
QString &text" form. So change the minority to be consistent with
the majority.
15 years ago
80ec2d216b
Delete some kDebug messages
15 years ago
330de6c6f4
Fix some spelling problems
15 years ago
cf92cece2b
Remove leading white spaces in blank lines to make them really empty
15 years ago
124fe7fddc
Make internal constant static
15 years ago
9f8969eb27
Remove some very old FIXMEs
...
I am not sure they all are already fixed, but taking their age into
consideration, leaving them there would be more confusing than helpful.
15 years ago
c2cc2f76ed
Use size of -1 to indicate unlimited history, instead of the current 0
...
The old way has one problem: HistoryFileNone::isUnlimited() returned
true because HistoryFileNone::maximumLineCount() returned 0. Although
that did not cause problem for practical usage, it was still quite odd.
15 years ago
d54b36c206
Remove unused method getFileName()
15 years ago
Kurt Hindenburg
Martin T. H. Sandsmark
Rex Dieter
Montel Laurent
Michal Humpula
Jekyll Wu