It is crashing several times a day for me, and every time it closes all
Konsole windows I have open (including the ones I'm working in), so I
suggest it should be turned off by default for this release.
(cherry picked from commit 2a788380f648ed95a76508a10a327521ccb098f6)
There was support for bumping this to 14 or 17 earlier this year.
I'll check before 21.04 is released on how much code actually needs 17.
All modern OS distros should have a C++17 compiler.
This pulls in ECM 5.38 which requires a change of add_test()s
This update is needed to port from KToolInvocation::kdeinitExec to
KIO::CommandLauncherJob
Summary:
This was added for feature-parity with Meson-based projects; but an
individual package is the wrong place for that. To avoid the proliferation
of auto-detected ccache support in kde.org packages please submit such
a proposal to kde-frameworks-devel instead, where it could be added for
the benefit of all the projects using ECM. And more importantly, with a
standard switch to disable it for packaging environments
This reverts commit 007c2a0852.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: kkharlamov, hindenburg, konsole-devel, hiangel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D24805
Summary:
Arguments in some QCOMPARE calls in KeyboardTranslatorTest had slightly
different types, what according to Qt documentation is not allowed.
The types of both QCOMPARE arguments must be exactly the same, otherwise
the code doesn't compile with some Qt versions.
With this fix it is safe to lower minimum Qt version to 5.9.0. Patch
number is incremented only for bugfix releases, so as long as invalid
code is not used everything should work.
The fix allows to compile Konsole using system libs on larger number
of systems, e.g. Ubuntu 18.04 LTS (Qt 5.9.5).
Tested with Qt 5.9.[0-5] and 5.11.1
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D19859
(cherry picked from commit e9bb01a02e)
Summary:
Arguments in some QCOMPARE calls in KeyboardTranslatorTest had slightly
different types, what according to Qt documentation is not allowed.
The types of both QCOMPARE arguments must be exactly the same, otherwise
the code doesn't compile with some Qt versions.
With this fix it is safe to lower minimum Qt version to 5.9.0. Patch
number is incremented only for bugfix releases, so as long as invalid
code is not used everything should work.
The fix allows to compile Konsole using system libs on larger number
of systems, e.g. Ubuntu 18.04 LTS (Qt 5.9.5).
Tested with Qt 5.9.[0-5] and 5.11.1
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D19859
This allows DragonflyBSD and Ubuntu 18.04LTS to compile.
There are Qt >= 5.10.0 checks in KeyboardTranslatorTest due to
qCompare errors.
(cherry picked from commit ed8847ec94)
Kurt Hindenburg
Martin T. H. Sandsmark
Albert Astals Cid
Friedrich W. H. Kossebau
Ahmad Samir
Nicolas Fella
Andreas Sturmlechner
Christoph Feck
Jonathan Riddell
Konstantin Kharlamov
Luca Beltrame
Mariusz Glebocki