The Splitter is a great addition to konsole, but it lacked one
thing that always made KDE software proud: Configurability.
Some people like to have the header bar, some people don't,
some people prefer to have thin lines separating the views, some people
prefer to have the lines a bit thicker so it's easy to drag them with
the mouse.
This patch introduces those two settings in a new Tab on the Settings.
FIXED-IN: 20.08
FEATURE:
GUI:
CHANGELOG: Add Splitter settings for visibility and drag size
Summary:
- Added handlig of mouse double click on view header bar to toggle
maximize.
- Added menu entry under View -> Split view, Toogle maximize view
Test plan:
A.1. Open Konsole and create split views
A.2. Double clicking a view header should toggle maximize/restore the view
B.1. Open Konsole and create split views
B.2. Go to menu View -> Split view -> Toggle maximize view
Focused TerminalDisplay is used as a source of tab and window name,
for activity monitoring, splits headers highlighting, etc.
With this change TerminalDisplay is considered focused even when actual
focus is e.g. in its search box or popup menu.
This is not only style change, but also a bugfix.
Header and title font was unspecified, so terminal monospace font was
used in most cases. However, when new split with different orientation
was created, the font of splitted terminal changed to the system font.
Steps to reproduce:
* Split vertically - both titles use monospace font
* Split horizontally - splitted header's font changes to system default
Summary:
The idea is that a SplitterHeaderBar will be added in the
near future so the checks for the parent widget could be
wrong.
If instead of checking for a specific widget we check for
anything and walk to the parent list untill we find
a TerminalWidget seems sane, and safer.
Phabricator messed with this review and send the wrong diff together (because of the same parent)
so I'm rephrasing it.
Reviewers: #konsole, hindenburg, ngraham, #vdg
Subscribers: aaronhoneycutt, kvermette, thsurrel, rizzitello, mart, hindenburg, gennad, fabianr, ndavis, shubham, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D21301
Carlos Alves
Kurt Hindenburg
Gustavo Carneiro
Tomaz Canabrava
Gaston Haro
Mariusz Glebocki
Laurent Montel