Summary:
Arguments in some QCOMPARE calls in KeyboardTranslatorTest had slightly
different types, what according to Qt documentation is not allowed.
The types of both QCOMPARE arguments must be exactly the same, otherwise
the code doesn't compile with some Qt versions.
With this fix it is safe to lower minimum Qt version to 5.9.0. Patch
number is incremented only for bugfix releases, so as long as invalid
code is not used everything should work.
The fix allows to compile Konsole using system libs on larger number
of systems, e.g. Ubuntu 18.04 LTS (Qt 5.9.5).
Tested with Qt 5.9.[0-5] and 5.11.1
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D19859
(cherry picked from commit e9bb01a02e)
Summary:
Arguments in some QCOMPARE calls in KeyboardTranslatorTest had slightly
different types, what according to Qt documentation is not allowed.
The types of both QCOMPARE arguments must be exactly the same, otherwise
the code doesn't compile with some Qt versions.
With this fix it is safe to lower minimum Qt version to 5.9.0. Patch
number is incremented only for bugfix releases, so as long as invalid
code is not used everything should work.
The fix allows to compile Konsole using system libs on larger number
of systems, e.g. Ubuntu 18.04 LTS (Qt 5.9.5).
Tested with Qt 5.9.[0-5] and 5.11.1
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D19859
This allows DragonflyBSD and Ubuntu 18.04LTS to compile.
There are Qt >= 5.10.0 checks in KeyboardTranslatorTest due to
qCompare errors.
(cherry picked from commit ed8847ec94)
Summary:
schemes are supplied by `Konsole Color Scheme` category on store.kde.org
https://store.kde.org/p/1216368/
- new manager helpers to unload a theme and check a file's name validity
- new Get New.. button to start the KNS download dialog
- upon KNS completion we'll attempt to load all installed files as schemes
- for KNS entities which failed to load anything we'll show a warning as
the theme is malformed
- for removal we'll first try to remove schemes through KNS to avoid its
registry going out of sync with the on-disk "installedness" of an entity
- properly disable copying of the scheme manager (needs to be private)
FEATURE: 18.04.0
CHANGELOG: Support for downloading color schemes from the KDE store
Test Plan:
category is T8053 (can also use `KDE Color Scheme KDE4` for testing)
- get new -> install scheme -> close -> shows up in list
- remove from list -> get new -> not listed as installed
- install random stuff from kde color scheme category -> close ->
warning should be displayed
- install scheme -> get new -> remove scheme via dialog -> close ->
not listed as installed
Reviewers: hindenburg
Subscribers: #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D10766
Jonathan Riddell
Kurt Hindenburg
Albert Astals Cid
Konstantin Kharlamov
Friedrich W. H. Kossebau
Luca Beltrame
Christoph Feck
Mariusz Glebocki
Laurent Montel
Harald Sitter