This also allowed me to remove a few includes of Profile.h
around the codebase, that used Profile::Ptr. now the compilation
is a bit faster and also does not recompile things as often.
Move a KeyboardTranslatorReader class to a new files, KeyboardTranslatorReader.h and KeyboardTranslatorReader.cpp
Move a KeyboardTranslatorWriter class to a new files, KeyboardTranslatorWriter.h and KeyboardTranslatorWriter.cpp
Summary:
- Change updateKeyBindingsList() to select the last edited keybindings
scheme after closing the editor dialog
- Add a tooltip showing the path of each keybinding scheme, this should
lessen the confusion when the scheme description and the file name of
the .keytab file are different
- Add a button to the Keyboard tab to reset a scheme to its default
values, this is only applicable for schemes that exist in both
system-wide and user specific locations
- Move a lot of the construction of the keybinding editor widgets from
EditProfileDialog to KeyBindingEditor
- Change the wording from "key bindings list" to "key bindings scheme"
to differentiate between a keyboard translator "scheme" and the key
bindings "list" on the Keyboard tab
KeyBindingEditor:
- Make the KeyBindingEditor a QDialog and set Qt::WA_DeleteOnClose
- Disallow saving a scheme with an empty description
- Add a QLineEdit to show only the rows that have strings matching the
text entered in the line edit box
- Reimplement sizeHint() to make the dialog slightly smaller than the
Edit Profile dialog, for better visibility of the entries
KeyboardTranslatorManager:
- Make findTranslatorPath() const and public
- Make allTranslators() return type const
Test Plan:
- Editing a key bindings scheme works and closing the dialog selects the edited scheme
- Creating a new scheme works as before
- "Defaults" button works for system-wide schemes if they were previously edited and saved under the user's home dir
- Remove button is only enabled for schemes saved in a dir writable for the user
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: konsole-devel, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D12981
Summary:
The first column in the key binding editor dialog usually has long lines of
text, to improve usability set a minimum size of 480x430 for that dialog
and an initial size of 500x500. Also set the initial width of that column
to 300.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: ngraham, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D11637
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes
REVIEW: 111937
To build for KF5 pass the option -DQT5_BUILD=ON to CMake
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes
REVIEW: 111937
Ahmad Samir
Kurt Hindenburg
Laurent Montel
Tomaz Canabrava
Gustavo Carneiro
Michal Humpula
Alex Richardson
Alex Richardson
Jekyll Wu
Robert Knight