Summary:
In all the cases that were changed, the bounding rect is needed. A few
places were not ported, since they need more careful investigation.
This reduces deprecation warnings.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D23144
Summary:
* Use custom dialog and configuraton classes, as counterparts from KF5
are bugged. The KF5 versions should be fixed and used here.
* Create new KConfigDialog-like class and use it to show existing
configuration pages.
* Create KConfigDialogManager-like class for managing QButtonGroups.
* Remove help button from configuration dialog. There is nothing about
configuration dialog options in the help.
* Profile Settings:
* Use QTreeView instead of QTableView - it highlights whole lines,
aligns header names to the left, etc. Basically it looks like lists
in file manager or e.g. plugin list in Kate.
* Use (default) QStyledItemDelegate with checkbox instead of custom
delegate (tick mark) in favorite/show column.
* Change default profile item style - it now has italics font and
"(default)" suffix.
* Disable "Delete" button when default profile is selected
* Use slightly extended QKeySequenceEditor. KKeySequenceWidget looks
heavily out of place in a tree view. New editor supports some
control keys:
* Esc key cancels key capture.
* Del/backspace removes shortcut.
* Enter confirms shortcut immediately.
* Tab/backtab commits currently edited shorcut and moves to
next/previous shortcut.
* Shortcuts for non visible profiles use disabled text color.
* Note about visibility and shortcuts
* Rename "File Location" to "Temporary Files"
* Enable path selector only when "custom" is selected
* Place paths directly in labels
* Disable all tabbar settings except visibility when visibility is set
to "Never"
* Minor string changes.
**Screenshots**
{F6893460}
{F6893461}
{F6893462}
{F6893463}
BUG: 404096
FIXED-IN: 19.08.0
Reviewers: #konsole, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, hindenburg, #vdg, konsole-devel, #konsole
Tags: #konsole, #vdg
Differential Revision: https://phabricator.kde.org/D20816
Summary:
Click with the middle mouse click on a tab: close it
Click with the middle click on empty portion of tab bar creates a new tab.
This makes konsole more streamlined with default behavior
found in other tabbed applications like browsers.
GUI option to enable/disable closing tab w/ mouse button. The default
is to have closing tab with button disabled to avoid possible data loss.
Tomaz Canabrava <tcanabrava@kde.org> also coded portion of this.
FEATURE: 398940
FIXED-IN: 19.04
GUI:
Test Plan: {F6618852}
Reviewers: ngraham, hindenburg, tcanabrava
Reviewed By: ngraham, hindenburg
Subscribers: emateli, thsurrel, ngraham, hindenburg, shubham, broulik, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D15742
Summary:
Add option to hide the title bar and frame off by default. The
window can be managed via tilling management and
alt+mouse hold, etc. This is not a normal workflow for a normal
user for a normal application, but is indeed used for power users.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: sandsmark, tcanabrava, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D17588
Summary:
Since the application name is added by Qt, it is no longer
possible to remove the trailing '- Konsole' so the GUI
option is obsolete.
BUG: 364391
FIXED-IN: 19.03
Test Plan:
Change settings for existing Konsole and notice that the checkbox
doesn't change anything. After applying this the checkbox should
be removed.
Reviewers: #konsole, konsole-devel, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D17049
Summary:
This fixes quite a few bugs and open space for a massive cleanup.
Because the symbols where not exported we recompiled the same object
three times, one for the private library, one for the desktop
application and another for the KPart, all of those having a static
object inside of the same compilation unit - but linked in three
different objects.
This added a static data in three different objects, the object that
was supposed to be a singleton (!) - The result: KonsoleSettings::self()
in mainwindow.cpp had one pointer, in TerminalDisplay had another,
making the singleton useless.
Having just one singleton fixes a major misdesign in Konsole:
There's a call-chain starting from main.cpp that goes thru all objects
changing every setting needed, and most of the calls are just forwarding
calls to another object.
With this fixed we can remove this call-chain, and do a
connect(KonsoleSettings::self(), &KonsoleSettings::settingsChanged(),
...) inside of the object that needs to react to the changed setting
making the code much smaller and easier to figure out what's going
on.
Reviewers: hindenburg, #konsole, #kde_applications, broulik, dfaure, aacid
Reviewed By: dfaure
Subscribers: ngraham, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D13891
Summary:
Favor manual list creator over for loop for small list
Three items, create them manually, cleaner and less
computationally expensive.
Btw - this is ugly, both ways. I blame QStandardItemModel.
Simplify Logic
Use auto when types are explicit
Simplify Logic: use ternary when it improves readability
Stack when heap's uneeded.
There's absolutely no point on creating a QPointer
and manually deleting the item later. Just create
the variable on the stack
Auto when type's explicit
Subscribers: konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D13532
Summary:
Make the Qt 5.9 sentence present tense since we already
passed that version, and add a minor grammar update.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: ngraham, hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D13125
Summary:
This is not userfully, only adds more code and
the code is happy without it.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D12965
Summary: It clutters the UI and can still be permanently enabled in settings if so desired.
Test Plan:
Konsole looks a lot cleaner out of the box now
{F5750441}
Reviewers: #vdg, mart, hindenburg
Reviewed By: hindenburg
Subscribers: ahmadsamir, romangg, ngraham, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D11258
- Double-clicking on name opens Edit Profile dialog
- Only allow renaming from the Edit Profile dialog
- Upon renaming of a profile, change shortcut to new profile name
- Upon renaming of a profile, delete old named profile file.
- Do not allow renaming of a profile if that name already exists.
Patch by ahmadsamir; I made a few changes (name/const).
Differential Revision: https://phabricator.kde.org/D9272
Konstantin Kharlamov
Kurt Hindenburg
Mariusz Glebocki
Laurent Montel
Frederik Gladhorn
Shubham Jangra
Mauro Marssola
Patrick José Pereira
Andrew Smith
Tomaz Canabrava
Kai Uwe Broulik