Kurt Hindenburg
d0ae598348
Remove currentBookmarkList() - hasn't been used in years
7 years ago
Kurt Hindenburg
0995c1dc95
Remove supportsTabs() - hasn't been used in years
7 years ago
Martin T. H. Sandsmark
befaaa0255
Do not allow adding duplicates in bookmarks
...
This currently only catches bookmarks in top-level (ie not sub-folders)
Original code by Tomaz Canabrava <tcanabrava@kde.org>
BUG: 408939
FIXED-IN: 19.12
https://invent.kde.org/kde/konsole/merge_requests/8
7 years ago
Tomaz Canabrava
208218dec9
Small code simplifications
...
Summary:
- remove clang 9 warnings
- simplify if / else branches
Reviewers: #konsole, hindenburg, ngraham
Reviewed By: ngraham
Subscribers: ahmedbilal, gennad, ngraham, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D20438
7 years ago
Kurt Hindenburg
a7c3bda7a5
Use QFileInfo::completeBaseName() instead of baseName()
...
This fixes some infinite loops and other issues when file names have
multiple dots in their file name.
Patch by ahmadsamir
BUG: 343071
Differential Revision: https://phabricator.kde.org/D10439
8 years ago
Kurt Hindenburg
c907fcea7a
remove unneeded casts
9 years ago
Kurt Hindenburg
2a2a56d73c
modernize use nullptr
9 years ago
Kurt Hindenburg
f9857256cf
uncrustify using kf5 config
9 years ago
Kurt Hindenburg
0fd9e2bd55
uncrustify using kf5 config
9 years ago
Kurt Hindenburg
eade05a4bd
Do not specify Qt modules in includes
9 years ago
Kurt Hindenburg
a540e6fdd0
Fix readability-implicit-bool-cast issues using nullptr
9 years ago
Kurt Hindenburg
accf076104
Use member initializer lists in constructors
9 years ago
Kurt Hindenburg
48ae849c8c
Use QStringLiteral and QList::reserve()
11 years ago
Kurt Hindenburg
7b07dd78cd
s/QLatin1String/QStringLiteral/
11 years ago
Michal Humpula
15d09f9161
port from KStandardDirs to QStandardPaths
...
REVIEW: 120498
12 years ago
Kurt Hindenburg
b6304bcc59
Port KUrl to QUrl
...
Thanks to Michal Humpula michal humpula hudrydum cz
REVIEW: 120430
12 years ago
Kurt Hindenburg
1ea501da62
remove include moc from .cpp files - removes build warnings
13 years ago
Kurt Hindenburg
346e174285
Fix build for new kdelibs-frameworks bookmark code
...
thanks to Casian Andrei skeletk13@gmail.com for patch
REVIEW: 113091
13 years ago
Alex Richardson
a83db71590
Port to KF5/Qt5
...
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes
REVIEW: 111937
13 years ago
Alex Richardson
ab5e15b1b7
Revert "Port to KF5/Qt5"
...
This reverts commit 4adfbe84bd .
This work will go into a new branch instead
13 years ago
Alex Richardson
4adfbe84bd
Port to KF5/Qt5
...
To build for KF5 pass the option -DQT5_BUILD=ON to CMake
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes
REVIEW: 111937
13 years ago
Kurt Hindenburg
7a2a5beb00
Correct spelling errors/word usage
...
All these are in the comments - no code changes
13 years ago
Kurt Hindenburg
5b083640ce
whitespace and style fixes
...
Use 'git diff -w --ignore-all-space' to see non-whitespace changes
14 years ago
Kurt Hindenburg
6e93204ae5
/s/NULL/0
14 years ago
Jekyll Wu
6b6a5944f6
Prefer foreach(...) over while(...) for simplicity and readability
14 years ago
Kurt Hindenburg
c73556ce39
Apply astyle-kdelibs
...
Over the years, the coding style is all over the place.
Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
14 years ago
Kurt Hindenburg
bc087ae51b
Remove unused KDebug includes
14 years ago
Jekyll Wu
125e2c7bd2
Declare pointer and reference in a consistent way
...
Most code use the "const QString& text" form, instead of the "const
QString &text" form. So change the minority to be consistent with
the majority.
15 years ago
Jekyll Wu
8f1bbd4353
Remove trailing white spaces
15 years ago
Jekyll Wu
cf92cece2b
Remove leading white spaces in blank lines to make them really empty
15 years ago
Jekyll Wu
13fea35f69
Rename member variables to the form of _var for consistency
15 years ago
Jekyll Wu
cc998cd0ab
Adjust #include
15 years ago
Jekyll Wu
7e7a020fe8
Minor change on coding style
15 years ago
Jekyll Wu
dfce914c3c
Make BookmarkHandler::titleForView() slightly more readable.
15 years ago
Jekyll Wu
272ac9850e
Include KDE headers consistently in the from of "#include <KSomething>" .
...
However, some KDE headers are still only available in the form of
"#include <ksomething.h>"
krun.h ==> KRun
kicon.h ==> KIcon
kdebug.h ==> KDebug
kshell.h ==> KShell
kdialog.h ==> KDialog
kconfig.h ==> KConfig
klocale.h ==> KLocale
kglobal.h ==> KGlobal
kcolorutils.h ==> KColorUtils
kconfiggroup.h ==> KConfigGroup
kdesktopfile.h ==> KDesktopFile
kcolorscheme.h ==> KColorScheme
kstandarddirs.h ==> KStandardDirs
ktemporaryfile.h ==> KTemporaryFile
klocalizedstring.h ==> KLocalizedString
15 years ago
Jekyll Wu
473f1726c0
move member initialization into initialization list of constructor.
15 years ago
Jekyll Wu
e63c9b8388
Delete one line of useless code.
15 years ago
Laurent Montel
dd46511de1
Use QLatin1String in setObjectName (added with a script)
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1178049
16 years ago
Kurt Hindenburg
adf7f96969
Add i18n context to strings - corection
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1086487
16 years ago
Kurt Hindenburg
267c174d58
Add i18n context to strings
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1086486
16 years ago
Robert Knight
956277c014
Convert tabs to 4 spaces to match kdelibs conventions. Previously
...
there was a mix of tabs and spaces for indentation.
CCMAIL:Stefan.Becker@nokia.com
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=863326
18 years ago
Robert Knight
5d9997446e
Update copyright year to 2008. Remove '(C)' from copyright lines.
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=800631
18 years ago
Robert Knight
971a5315f9
Remove debugging messages.
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=800628
18 years ago
Robert Knight
d33c750983
Fix 'Open Folder in Tabs' action on bookmark menu.
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=756949
18 years ago
Robert Knight
46cfc108d3
* Replace all usage of qDebug() with kDebug(), since kDebug() provides information about
...
18 years ago
Laurent Montel
868b7bcc0f
Fix includ
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=751637
18 years ago
Daniel Teske
981d865c87
Port to new API.
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=699519
19 years ago
Robert Knight
72241ef4a6
* Comment out many debugging messages
...
19 years ago
David Faure
f980e26a14
We really don't need to import kde1 bookmarks anymore :)
...
This removes a nasty bool argument in managerForFile().
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=680309
19 years ago
Robert Knight
07b1e29c0c
Provide more sensible suggestions for bookmark names. Make suggestions context ( local vs. remote ) sensitive.
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=663708
19 years ago