From f7c07135baca750451b3ae40e95e81caabeb436c Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Wed, 17 Nov 2021 12:29:01 -0300 Subject: [PATCH] Character is 16 bytes, pass by value --- src/characters/Character.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/characters/Character.h b/src/characters/Character.h index 96cdb23a..4a4f87fd 100644 --- a/src/characters/Character.h +++ b/src/characters/Character.h @@ -176,7 +176,7 @@ public: return character; } - inline bool isSameScript(const Character &lhs) const + inline bool isSameScript(Character lhs) const { const QChar::Script script = QChar::script(lhs.baseCodePoint()); const QChar::Script currentScript = QChar::script(baseCodePoint()); @@ -187,17 +187,17 @@ public: return currentScript == script; }; - inline bool hasSameColors(const Character &lhs) const + inline bool hasSameColors(Character lhs) const { return lhs.foregroundColor == foregroundColor && lhs.backgroundColor == backgroundColor; } - inline bool hasSameRendition(const Character &lhs) const + inline bool hasSameRendition(Character lhs) const { return (lhs.rendition & ~RE_EXTENDED_CHAR) == (rendition & ~RE_EXTENDED_CHAR); }; - inline bool hasSameLineDrawStatus(const Character &lhs) const + inline bool hasSameLineDrawStatus(Character lhs) const { const bool lineDraw = LineBlockCharacters::canDraw(character); return LineBlockCharacters::canDraw(lhs.character) == lineDraw;