diff --git a/src/settings/ProfileSettings.cpp b/src/settings/ProfileSettings.cpp index 1bd2861f..3fbfe0b2 100644 --- a/src/settings/ProfileSettings.cpp +++ b/src/settings/ProfileSettings.cpp @@ -130,7 +130,7 @@ void ProfileSettings::updateItems(const Profile::Ptr profile) }; updateItemsForProfile(profile, items); } -void ProfileSettings::updateItemsForProfile(const Profile::Ptr profile, QList& items) const +void ProfileSettings::updateItemsForProfile(const Profile::Ptr profile, const QList& items) const { // Profile Name items[ProfileNameColumn]->setText(profile->name()); @@ -173,11 +173,12 @@ void ProfileSettings::addItems(const Profile::Ptr profile) return; } - QList items; - items.reserve(3); - for (int i = 0; i < 3; i++) { - items.append(new QStandardItem); - } + // each _sessionModel row has three items. + const auto items = QList { + new QStandardItem(), + new QStandardItem(), + new QStandardItem() + }; updateItemsForProfile(profile, items); _sessionModel->appendRow(items); diff --git a/src/settings/ProfileSettings.h b/src/settings/ProfileSettings.h index 456bb58e..29ce1f06 100644 --- a/src/settings/ProfileSettings.h +++ b/src/settings/ProfileSettings.h @@ -98,7 +98,7 @@ private: // updates the font of the items to match // their default / non-default profile status void updateDefaultItem(); - void updateItemsForProfile(const Profile::Ptr profile, QList &items) const; + void updateItemsForProfile(const Profile::Ptr profile,const QList &items) const; // updates the profile table to be in sync with the // session manager void populateTable();