From b51dca8218e315787b0e7f156f91066204755756 Mon Sep 17 00:00:00 2001 From: Kurt Hindenburg Date: Tue, 28 Oct 2014 07:18:53 -0400 Subject: [PATCH] Fix Konsole hides tabs when moving them using keyboard Only on KF5, not KDE 4.14.x Thanks to Arjun AK arjunak23 @gmail com for researching/fixing this BUG: 337241 REVIEW: 120693 --- src/ViewContainer.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ViewContainer.cpp b/src/ViewContainer.cpp index 27811636..f3ee2837 100644 --- a/src/ViewContainer.cpp +++ b/src/ViewContainer.cpp @@ -570,15 +570,15 @@ void TabbedViewContainer::moveViewWidget(int fromIndex , int toIndex) QString text = _tabBar->tabText(fromIndex); QIcon icon = _tabBar->tabIcon(fromIndex); - // FIXME - This will lose properties of the tab other than + // FIXME (KF5?)- This will lose properties of the tab other than // their text and icon when moving them - _tabBar->removeTab(fromIndex); - _tabBar->insertTab(toIndex, icon, text); - QWidget* widget = _stackWidget->widget(fromIndex); + // this also removes the tab from the tab bar _stackWidget->removeWidget(widget); _stackWidget->insertWidget(toIndex, widget); + + _tabBar->insertTab(toIndex, icon, text); } void TabbedViewContainer::currentTabChanged(int index) {