From 9d496ff14301e947d3561fc26d8b55a9dec7edf1 Mon Sep 17 00:00:00 2001 From: "Friedrich W. H. Kossebau" Date: Wed, 6 Jul 2022 01:38:20 +0200 Subject: [PATCH] Quick commands dialog: use "run" term consistently, avoid Yes/No buttons Yes/No buttons in dialogs are discouraged (not only) by KDE HIG in favour of actions terms. --- src/plugins/QuickCommands/quickcommandswidget.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/plugins/QuickCommands/quickcommandswidget.cpp b/src/plugins/QuickCommands/quickcommandswidget.cpp index 12d985ca..d6ac30b7 100644 --- a/src/plugins/QuickCommands/quickcommandswidget.cpp +++ b/src/plugins/QuickCommands/quickcommandswidget.cpp @@ -157,7 +157,7 @@ void QuickCommandsWidget::updateCommand() void QuickCommandsWidget::invokeCommand(const QModelIndex &idx) { if (!ui->warning->toPlainText().isEmpty()) { - QMessageBox::warning(this, QStringLiteral("Shell Errors"), i18n("Please fix all the warnings before trying to execute this script")); + QMessageBox::warning(this, QStringLiteral("Shell Errors"), i18n("Please fix all the warnings before trying to run this script")); return; } @@ -181,10 +181,10 @@ void QuickCommandsWidget::runCommand() { if (!ui->warning->toPlainText().isEmpty()) { auto choice = KMessageBox::questionYesNo(this, - i18n("There are some errors on the script, do you really want to execute it?"), + i18n("There are some errors on the script, do you really want to run it?"), i18n("Shell Errors"), - KStandardGuiItem::yes(), - KStandardGuiItem::no(), + KGuiItem(i18nc("@action:button", "Run"), QStringLiteral("system-run")), + KStandardGuiItem::cancel(), QStringLiteral("quick-commands-question")); if (choice == KMessageBox::ButtonCode::No) { return;