Correct includes

Summary: Remove unneeded includes, add correct includes, move includes h <-> cpp Reviewers: tcanabrava, hindenburg, #konsole Reviewed By: hindenburg, #konsole Subscribers: konsole-devel Tags: #konsole Differential Revision: https://phabricator.kde.org/D17759
7 years ago · 8c94b21980
parent e1fde67a69
commit 8c94b21980
11 changed files with 6 additions and 11 deletions
--- a/src/Application.cpp
+++ b/src/Application.cpp
@ -21,6 +21,7 @@
 #include "Application.h"

 // Qt
+#include <QApplication>
 #include <QHashIterator>
 #include <QFileInfo>
 #include <QDir>
--- a/src/Application.h
+++ b/src/Application.h
@ -21,7 +21,6 @@
 #define APPLICATION_H

 // Qt
-#include <QApplication>
 #include <QCommandLineParser>

 // Konsole
--- a/src/EditProfileDialog.h
+++ b/src/EditProfileDialog.h
@ -25,7 +25,6 @@
 #include <QAbstractItemDelegate>
 #include <QDialog>
 #include <QHash>
-#include <QPointer>
 #include <QButtonGroup>
 #include <QWidget>
 #include <QGridLayout>
--- a/src/KeyboardTranslator.h
+++ b/src/KeyboardTranslator.h
@ -23,10 +23,10 @@
 #define KEYBOARDTRANSLATOR_H

 // Qt
-#include <QHash>
 #include <QList>
-#include <QString>
 #include <QMetaType>
+#include <QMultiHash>
+#include <QString>

 // Konsole
 #include "konsoleprivate_export.h"
--- a/src/ProcessInfo.h
+++ b/src/ProcessInfo.h
@ -22,7 +22,6 @@

 // Qt
 #include <QFile>
-#include <QMap>
 #include <QString>
 #include <QVector>

--- a/src/SessionController.cpp
+++ b/src/SessionController.cpp
@ -27,6 +27,7 @@
 // Qt
 #include <QApplication>
 #include <QAction>
+#include <QList>
 #include <QMenu>
 #include <QKeyEvent>
 #include <QPrinter>
--- a/src/SessionController.h
+++ b/src/SessionController.h
@ -22,11 +22,9 @@
 #define SESSIONCONTROLLER_H

 // Qt
-#include <QList>
 #include <QSet>
 #include <QPointer>
 #include <QString>
-#include <QHash>
 #include <QRegularExpression>

 // KDE
--- a/src/ViewContainer.h
+++ b/src/ViewContainer.h
@ -24,11 +24,8 @@

 // Qt
 #include <QObject>
-#include <QPointer>
-#include <QHash>
 #include <QList>
 #include <QTabWidget>
-#include <QTabBar>

 // Konsole
 #include "Profile.h"
--- a/src/ViewManager.cpp
+++ b/src/ViewManager.cpp
@ -25,6 +25,7 @@
 // Qt
 #include <QStringList>
 #include <QAction>
+#include <QTabBar>

 // KDE
 #include <KAcceleratorManager>
--- a/src/ViewProperties.h
+++ b/src/ViewProperties.h
@ -24,7 +24,6 @@
 #include <QIcon>
 #include <QObject>
 #include <QHash>
-#include <QMimeData>
 #include <QUrl>

 // Konsole
--- a/src/main.cpp
+++ b/src/main.cpp
@ -25,6 +25,7 @@

 // OS specific
 #include <qplatformdefs.h>
+#include <QApplication>
 #include <QCommandLineParser>
 #include <QStandardPaths>
 #include <QDir>