From 7b16bf24feb26503e9badbc1d97cdc708a49f841 Mon Sep 17 00:00:00 2001 From: "Friedrich W. H. Kossebau" Date: Wed, 6 Jul 2022 02:03:26 +0200 Subject: [PATCH] Quick commands delete dialog: use "delete" consistently, avoid Yes/No buttons Also use KMessageBox::warningYesNo instead of the helper method KMessageBox::messageBox. Yes/No buttons in dialogs are discouraged (not only) by KDE HIG in favour of actions terms. --- src/plugins/QuickCommands/quickcommandswidget.cpp | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/plugins/QuickCommands/quickcommandswidget.cpp b/src/plugins/QuickCommands/quickcommandswidget.cpp index d6ac30b7..e4c8645a 100644 --- a/src/plugins/QuickCommands/quickcommandswidget.cpp +++ b/src/plugins/QuickCommands/quickcommandswidget.cpp @@ -208,16 +208,11 @@ void QuickCommandsWidget::triggerDelete() const auto idx = ui->commandsTreeView->currentIndex(); const QString text = idx.data(Qt::DisplayRole).toString(); const QString dialogMessage = ui->commandsTreeView->model()->rowCount(idx) - ? i18n("You are about to remove the group %1,\n with multiple configurations, are you sure?", text) - : i18n("You are about to remove %1, are you sure?", text); - - KMessageBox::ButtonCode result = KMessageBox::messageBox(this, - KMessageBox::DialogType::WarningYesNo, - dialogMessage, - i18n("Remove Quick Commands Configurations"), - KStandardGuiItem::yes(), - KStandardGuiItem::no(), - KStandardGuiItem::cancel()); + ? i18n("You are about to delete the group %1,\n with multiple configurations, are you sure?", text) + : i18n("You are about to delete %1, are you sure?", text); + + int result = + KMessageBox::warningYesNo(this, dialogMessage, i18n("Delete Quick Commands Configurations"), KStandardGuiItem::del(), KStandardGuiItem::cancel()); if (result != KMessageBox::ButtonCode::Yes) return;