From 740675243c0e573dd25fc65ae329b08be4538d58 Mon Sep 17 00:00:00 2001 From: Albert Astals Cid Date: Sun, 29 Nov 2015 19:39:04 +0100 Subject: [PATCH] Call KLocalizedString::setApplicationDomain("konsole"); konsole is using -DTRANSLATION_DOMAIN=\"konsole\" that is wrong for applications, apps need to use KLocalizedString::setApplicationDomain since that is needed for some things like the transltators tab in the about dialog. I have not removed -DTRANSLATION_DOMAIN=\"konsole\" because on the other hand this code is also a library (i.e. the konsole kpart). The "being pedanticly correct" fix would be using -DTRANSLATION_DOMAIN=\"konsole\" only to compile the files that are part of the kpart but that's prone to break at some point and using both KLocalizedString::setApplicationDomain and -DTRANSLATION_DOMAIN does not create any problem so i went that route CCMAIL: konsole-devel@kde.org --- src/main.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main.cpp b/src/main.cpp index 7c5d9530..5e1420e3 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -81,6 +81,8 @@ extern "C" int KDE_EXPORT kdemain(int argc, char** argv) } } + KLocalizedString::setApplicationDomain("konsole"); + KAboutData about(QStringLiteral("konsole"), i18nc("@title", "Konsole"), QStringLiteral(KONSOLE_VERSION),