From 45cd5000d07caf7a58dd6dee981efa74f8114a78 Mon Sep 17 00:00:00 2001
From: Tomaz Canabrava <tcanabrava@kde.org>
Date: Thu, 14 Jun 2018 14:12:39 +0200
Subject: [PATCH] Stack when heap's uneeded.

There's absolutely no point on creating a QPointer
and manually deleting the item later. Just create
the variable on the stack
---
 src/settings/ProfileSettings.cpp | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/settings/ProfileSettings.cpp b/src/settings/ProfileSettings.cpp
index 289892f9..2bbca639 100644
--- a/src/settings/ProfileSettings.cpp
+++ b/src/settings/ProfileSettings.cpp
@@ -302,16 +302,15 @@ void ProfileSettings::createProfile()
     newProfile->setProperty(Profile::UntranslatedName, QStringLiteral("New Profile"));
     newProfile->setProperty(Profile::MenuIndex, QStringLiteral("0"));
 
-    QPointer<EditProfileDialog> dialog = new EditProfileDialog(this);
-    dialog.data()->setProfile(newProfile);
-    dialog.data()->selectProfileName();
+    EditProfileDialog dialog(this);
+    dialog.setProfile(newProfile);
+    dialog.selectProfileName();
 
-    if (dialog.data()->exec() == QDialog::Accepted) {
+    if (dialog.exec() == QDialog::Accepted) {
         ProfileManager::instance()->addProfile(newProfile);
         ProfileManager::instance()->setFavorite(newProfile, true);
         ProfileManager::instance()->changeProfile(newProfile, newProfile->setProperties());
     }
-    delete dialog.data();
 }
 void ProfileSettings::editSelected()
 {