From 41b0b20a1946674d6b04c89b3b43f1a039196171 Mon Sep 17 00:00:00 2001 From: Kurt Hindenburg Date: Fri, 1 Jun 2018 09:02:08 -0400 Subject: [PATCH] Only consider startDragDistance for drag-n-drop tabs The commit for https://phabricator.kde.org/D7451 changed DND to use startDragDistance or startDragTime. This can cause accidently DND of tabs which creates new windows. --- src/ViewContainerTabBar.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/ViewContainerTabBar.cpp b/src/ViewContainerTabBar.cpp index 02a25274..29eae084 100644 --- a/src/ViewContainerTabBar.cpp +++ b/src/ViewContainerTabBar.cpp @@ -83,8 +83,7 @@ void ViewContainerTabBar::mouseMoveEvent(QMouseEvent *event) { if (event->buttons() == Qt::LeftButton) { QPoint dragPos = _dragStart - event->pos(); - if (dragPos.manhattanLength() > QApplication::startDragDistance() - || _mousePressTimer->elapsed() > QApplication::startDragTime()) { + if (dragPos.manhattanLength() > QApplication::startDragDistance()) { int tab = tabAt(_dragStart); if (tab != -1) { emit initiateDrag(tab);