From 05a4d48991ae69c9177257c1dd0c660bdf875f2d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luis=20Javier=20Merino=20Mor=C3=A1n?= Date: Mon, 18 Jul 2022 23:51:55 +0200 Subject: [PATCH] Add some comments to VT state machine For clarity, the VT state machine has some comments where it differs from the diagram from vt100.net. Add comments for some transitions on String Terminator (ST / 0x9C) which appear on the diagram, but which were already handled in the "anywhere" state. --- src/Vt102Emulation.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Vt102Emulation.cpp b/src/Vt102Emulation.cpp index 9756ca7f..b5e4f401 100644 --- a/src/Vt102Emulation.cpp +++ b/src/Vt102Emulation.cpp @@ -868,11 +868,13 @@ void Vt102Emulation::receiveChars(const QVector &chars) case DcsPassthrough: if (cc <= 0x7E || cc >= 0xA0) { // 0x18, 0x1A, 0x1B already taken care of put(cc); + // 0x9C already taken care of. } else if (cc == 0x7F) { // ignore } break; case DcsIgnore: + // 0x9C already taken care of. if (cc <= 0x7F) { // ignore } @@ -889,8 +891,9 @@ void Vt102Emulation::receiveChars(const QVector &chars) break; case SosPmApcString: if (cc <= 0x7F || cc >= 0xA0) { // 0x18, 0x1A, 0x1B already taken care of. - apc_put(cc); + apc_put(cc); // while the vt100.net diagram has ignore here, konsole does process some APCs (kitty images). } + // 0x9C already taken care of. break; default: break;