it introduced regressions, extended in the following way:
- take the mail from the folder for composing as before
- set transferInProgress to false (set to true by the command during
retrieval of the message) when passing the removed message to the
composer which now owns it
- return true from KMFolder::canAddMsgNow if the message is not in any
folder but its transferInProgress flag is set. This prevents messages
from simply going away if the flag is not properly reset by some action
or other and the mail is not currently in any folder. Not relevant
anymore for the above case, but safer nonetheless.
svn path=/trunk/kdepim/; revision=273392
active readerwindow to ask that for the attachmentstrategy but pass it
along with the folder job, so it is available when the mime structure
comes in with load on demand. Remove unused KMKernel::activeReaderWindow
which doesn't work in kontact anyhow.
CCMAIL: 67644-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=268877
a header item which has not been created yet. If uid validity has just
changed there are no header items at all, because the headers list has
been cleared as a result of expunge() in which case that results in a
crash.
For the members of the weird kmail crash appreciation society, this is
the "KMHeaders::getNestingPolicy() const (this=0x0)" crash you might have
come across before.
svn path=/trunk/kdepim/; revision=262787
folders, adding the messages one by one to the header listview is very
slow. With pop, where each body is downloaded anyhow which takes a lot
longer, that is not a factor, but with imap this results in a massive
slowdown. Get all of them and then redraw the listview completely, as
before.
I'm planning to hunt down why this is so slow after 3.2, as this is just
working around the real problem.
svn path=/trunk/kdepim/; revision=261394
signals from being emitted.
This should fix the sent folder count updating bug. If it does not for
you, please reopen.
Patch Ok'ed by Till (Don also agreed that quiet() can be removed).
CCMAIL: 63670-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=260199
truncated to invalid sizes and ending up corrupted. Noticeable when 'empty
trash on close' is activated.
Add an assert to alert us should something similar come up again.
Thanks to Dirk 'I don't have mutt installed' Müller for complaining about
that one.
svn path=/trunk/kdepim/; revision=256595
#define kernel KMKernel::self()
to
#define kmkernel KMKernel::self()
because 'kernel' was a much to general term. We really shouldn't repeat the mistakes of the X developers.
I noticed this problem when I played around with KImageEffects. kimageeffects.h contains 'kernel' as parameter of some methods and so the compilation had to fail. We won't need KImageEffects in the near future, but at least we are now prepared and a clash with another 'kernel' can't happen anymore.
svn path=/trunk/kdepim/; revision=252621
o make imapjobs refcount the folders they operate on via open/close instead
of relying on the account to keep track of open folders and close them
in displayProgress()
o keep not only the destination but also the source folder in each imapjob
so they can be closed if need be
o remove tempOpenFolder() itself and all its uses
svn path=/trunk/kdepim/; revision=244918
- Delete messages during transfer
- Minor cleanups
- Do not display headers when you skip over messages
CCMAIL: 62943-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=243659
Especially protocol() == "imap". Note that using ssl completely breaks those
checks then as the protocol is then "imaps". Also the string compares
are suboptimal there - use folderType() == KMFolderTypeSomeType.
svn path=/trunk/kdepim/; revision=238868
1) Remove the limitation that a message can have only one status at a time.
2) Implement watch/ignore thread via message status flags.
ad 1:
- Message status is now kept as a bitfield, which means a message can now be
for example replied and forwarded as well as important at the same time.
- To keep the index format backward compatible and make the transition
painless, I've added a new index entry and added code to transfer the old
into the new format. That means that upgrading users should not notice
anything.
- I've tried to keep as much behavior as possible unchanged with regard to
what flag disables what other flag etc. There are two groups of flags:
read/unread/new/old influence each other, which means a message cannot be
new and read at the same time, for example, while the second group, namely
important, sent, queued, replied, and forwarded are toggled individually.
- Toggling a thread sets the messages status to the inverse of that of the
parent, which means that if you have a thread with some mails marked as
important and some not, the status is set according to that of the parent.
- Status is now kept when moving mails between folders in the same imap
account as well as between imap accounts.
ad 2:
- Watch and ignore are mutually exclusive, which means ignoring a thread
unsets its watched flag and the other way around.
- When sorting by status watched threads are at the top, ignored at the
bottom.
- Watch and ignore propagate via threading, which means that if a message
is threaded below a watched one, it becomes watched. Same for ignore.
- Moving a single mail out of a watched thread results in a new watched
thread of size 1 :)
- Similarly watch and ignore are possible on individual mail (threads
to be).
- Watching a thread does not currently mark new mails as important, nor
does ignoring delete new mails in the thread. These are possible
extensions, though, if we think them sensible.
svn path=/trunk/kdepim/; revision=235595
from imapjob.
how to reproduce the crash: delete all the message files off the server but
don't touch any indices. then try to delete a message in the folder in kmail.
svn path=/trunk/kdepim/; revision=235458
be deleted during unGetMsg(). Failure to do that results in interesting
behavior when the account tries to remove the job but the message pointer
is invalid. I believe this is the true cause of the crash/valgrind errors
George was seeing.
CCMAIL: staikos@kde.org
svn path=/trunk/kdepim/; revision=233998
the first propagating to the latter, and connect the part to it, so kontact
updates the folder name and icon when they are changed.
Kontact folks, feel free to revert if this is not the way you want to do
this. Sorry for touching this without asking for permission. :)
svn path=/trunk/kdepim/; revision=229185
of an imap folder while move/delete operations out of it are going on, as
far as I can see. This means a bunch of open()/close() calls I added while
hunting trying to fix them are probably unnessecary. Have to look at the
CopyCommand as well in that regard.
svn path=/trunk/kdepim/; revision=229100
folder A and 300 messages to folder B instead of clicking undo 500 times you
click undo twice. Basically it's action instead of message based now.
Also, David could you also move kmundostack.{h,cpp} to undostack.{h,cpp} ? :)
CCMAIL: David Faure <faure@kde.org>
svn path=/trunk/kdepim/; revision=227137
George Staikos
Bo Thorsen
Till Adam
Ingo Klcker
Roberto Teixeira
Ladislav Strojil
Marc Mutz
Carsten Burghardt
Daniel Molkentin
Zack Rusin
Stephan Kulow