keeping the msginfo pointer around in the message object, and restoring it on
unGet. Should help with a whole class of crashes around filtering, searching
etc. Original patch by Ingo and Andreas, with some fixes and memleak plugs
in corner cases by me. We'll testdrive this a while in enterprise branch, let's
see how it behaves.
CCMAIL: a.gungl@gmx.de
CCMAIL: ingo@kde.org
svn path=/branches/kdepim/enterprise/kdepim/; revision=694327
here: http://lists.kde.org/?l=kmail-devel&m=111945756024656&w=2
I've changed the KMMsgDict::instance() to return a pointer instead of a
reference, compared to the patch I posted, after valid criticism from
Marc that the pattern is generally used with a pointer, in KDE, so it's
better not to surprise people here.
svn path=/trunk/KDE/kdepim/; revision=428560
-> Porting all of KMMsgList to uint, plus a few callers.
Also remove the FooInherited #defines and all KMMsgList virtuals (why virtual methods in a QMemArray<>-derived and never futher derived class?
svn path=/trunk/kdepim/; revision=258280
#define kernel KMKernel::self()
to
#define kmkernel KMKernel::self()
because 'kernel' was a much to general term. We really shouldn't repeat the mistakes of the X developers.
I noticed this problem when I played around with KImageEffects. kimageeffects.h contains 'kernel' as parameter of some methods and so the compilation had to fail. We won't need KImageEffects in the near future, but at least we are now prepared and a clash with another 'kernel' can't happen anymore.
svn path=/trunk/kdepim/; revision=252621
Also this fixes a minor bug in kmpopfiltercnfrmdlg.cpp (5th hunk)
and removes unneeded includes from kmpopfilter..dlg.h.
svn path=/trunk/kdenetwork/kmail/; revision=125200
There is a serious problem that when operating on a selection of messages all those messages (I mean the entire message including its body) are loaded into main memory. This is not a good idea when operating on thousands of messages.
I've looked into fixing this but it's not so simple. Some functions like movemsg in kmheaders operate on a list of selected messages. And that list of selected messages is a list of whole messages not just message headers.
Even if I fix those functions I still need to know when a message is being referenced. I can audit the code and modify it as needed, but then I will still be relying on an implicit contract. Instead it would be best to modify KMFolder::getMsg so that it returns a referenced counted KMMessage wrapper by value.
svn path=/trunk/kdenetwork/kmail/; revision=47734
random hangs, with stock qsort -- hopefully working now ;-)
* Fixed: folder list went out of scope (current item pointing to
nowhere) when folder was deleted.
* Composer: fixed broken confirm-close dialog.
* Increased version to better match upcoming Kde-1.1 release.
* Added call to kapp->quit() when last window is closed.
svn path=/trunk/kdenetwork/kmail/; revision=11183
to ignore special characters at the end, e.g. "." or ")".
* Messagelist: finally fixed sorting of messages. Also
implemented ascending/descending/none sorting (use multiple
clicks on the column headers to switch). Sorting order "none"
is what was IMO missing for the trash folder :-)
svn path=/trunk/kdenetwork/kmail/; revision=6198
Drawback: attachments are currently somewhat broken (you cannot save them).
Benefit: lots. Take a look ;-)
Please install the patched mimelib also. Otherwise KMail does not show
any contents for some messages.
svn path=/trunk/kdenetwork/kmail/; revision=2529
The reader will be cleaned next.
Retrieving POP mails is now in experimental state and may work.
Sending attachments should work now, receiving them still needs work ;-)
svn path=/trunk/kdenetwork/kmail/; revision=2467