#define kernel KMKernel::self()
to
#define kmkernel KMKernel::self()
because 'kernel' was a much to general term. We really shouldn't repeat the mistakes of the X developers.
I noticed this problem when I played around with KImageEffects. kimageeffects.h contains 'kernel' as parameter of some methods and so the compilation had to fail. We won't need KImageEffects in the near future, but at least we are now prepared and a clash with another 'kernel' can't happen anymore.
svn path=/trunk/kdepim/; revision=252621
1. Ignore the mailing list post address in the Reply-To header when replying to all (it's already listed in the To header).
2. Put the sender's address in the CC field in case of a reply to all to a mailing list messages (useful for replying to those 'Please CC me. I'm not subscribed.' messages).
3. In case of a simple reply to a mailing list message ignore the Reply-To header if it contains the mailing list post address so that the reply is addressed to the sender of the message. This means that a simple reply to a mailing list message now works as 'private reply' even if the Reply-To header has been mangled.
All changes have been deman^wproposed by Dirk Mueller.
svn path=/trunk/kdepim/; revision=249844
(I still have to do this for the direct click on the attachment)
- fix saving of one attachment (filename was not displayed because the mimeheader was missing)
save all attachments works as expected but doesn't update the parts in the readerwin, I still need to fix this
svn path=/trunk/kdepim/; revision=249206
- Fix the order in which we apply stripEmailAddr and decodeRFC2047.
- Remove some duplicated usages of stripEmailAddr by using fromStrip(), toStrip() and ccStrip().
svn path=/trunk/kdepim/; revision=246092
- Delete messages during transfer
- Minor cleanups
- Do not display headers when you skip over messages
CCMAIL: 62943-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=243659
computed of the subject stripped of whitespace, since subjects are written
to the index stripped of whitespace and therefor hash to different values,
when taken from there, if that is not taken into account.
svn path=/trunk/kdepim/; revision=240609
This patch mostly concerns itself with the following two things:
1. Move code out from kmreaderwin (see new class CSSHelper, whose files
have already been committed).
Into this category fall the simplification and readability
enhancements of the HTML code (adding some newlines, simplifying the
HTML in favour of complicating the CSS a bit, using @media print)
2. Change the semantics of the mCodec member of KMMessage and
KMReaderWin.
To make it short: mCodec is not mOverrideCodec and only ever set to a
non-NULL value iff the codec is forced by the user selecting an
encoding from the Message menu. In all other cases, it's now
calculated from the message(parts). For that, the codec() and
setBodyFromUnicode() and bodyToUnicode() methods have been duplicated
in KMMessage from KMMsgPart (don't you just hate that?).
Walkthrough of the patch:
kmreaderwin.{h,cpp}
- Replace all c* and m*Font members by a single CSSHelper instance.
- readColorConfig(), parts of readConfg(), quoteFontTag() and htmlHead()
were moved from here to CSSHelper
- rename codec()/setCodec() to overrideCodec()/setOverrideCodec()
and provide an autoDetectEncoding() convenience method.
- Remove the QTextCodec parameter from setMsgPart. It now uses
overrideCodec() or the msgPart's own codec.
- s/isfixedFont/isFixedFont/
- split parseMsg( KMMessage*, bool ) into one for
onlyProcessHeaders=false (called again parseMsg(KMMessage*)) and one
for oPH=true (called parseMsgHeader()). The latter then reduces to
writeMsgHeader(), provided one accepts the minor regression that the
[vPart] link is not shown _for *nested*_ messages. This can be readded
later, once KMReaderWin is void of formatting code and OTP is
independent of a KMReaderWin parent. I've left the commented
parseMsgHeader in the momnt of it's death in commented out, so you can
see what I how I came to kill it off for an explicit writeMsgHeader().
- In the old new parseMsg(KMMessage*), there also happened significant
code simplification, mostly by realizing that the the colorbar and tmp
file handling belongs into parseMsg(void) and by removing the oPH=true
case. There's also an instance of simplifying code by using
bodyToUnicode(). At last, the <div id="header"></div> around
writeMsgHeader is superfluous (and wrong, since there is and never was
a div#header CSS selector), since the HeaderStyle's add that already.
- Apply "Inline Method" to writeHTMLStr()
- remove the QTextCodec param from showVCard(). This method is now a
nice one and uses bodyToUnicode()
- rename all fooCodec to fooOverrideCodec
- currently, mCSSHelper is destroyed and re-created whenever it the
config changes. I intend to make CSSHelper a fully functional
ConfigManager later.
- setOverrideCodec now calls update(true) only if the codec was actually
changed.
- In setMsgPart, there's code that "forgets" to strip off <head>, <body>
and <html> tags from HTML parts. I didn't do anything about that yet,
only added a triple-hash.
- Simplify slotAtmSave() by using more guard clauses and esp. by using
QString::section() and QString::replace(QChar,QChar) instead of
rolling our owns.
objecttreeparser.{h,cpp}:
- Use CSShelper
- Create a new CSS class "htmlWarn" for the HTML warning frame to get
rid of the embedded style information.
- simplify quotedHTML() by using new nonQuotedFontTag().
headerstyle.cpp:
- We begin by inserting some newlines to ease the reading of the
resultant HTML code.
- In the fancy header department, we remove almost all class attributes
from the HTML tags. Instead (see csshelper.cpp), we use CSS Selectors
to address the inner tags of the enclosing <div class="fancy header">
Note how that tag matches both the div.header (setting the margin) and
div.fancy.header selectors in csshelper.cpp
- We end with removing the workaround for the apparently long-standing
khtml bug that makes it ignore "padding" on <table>, viz. another
<div></div> pair around the table.
kmfldsearch.cpp:
- Reap fruits of (2).
kmmainwin.cpp:
- Consequence of setCodec -> setOverrideCodec() renaming
- move an #include up to the top
kmmessage.{h,cpp}:
- Copy setBodyFromUnicode(), bodyToUnicode() and rename fooCodec to
fooOverrideCodec.
- Note how the double housekeeping (mAutoDetectEncoding) goes away with
this.
- In html2source(), don't emit <br />, but <br> (we're using HTML 4.01,
not XHTML) and quote ' with ' (well, that's more XHTML-like)
kmreadermainwin.{h,cpp}:
- Since the QTextCodec* parameter was removed from
KMReaderWin::setMsgPart(), use now the explicit setOverrideCodec()
method to set the user-defined codec.
- Remove unused mCodec member
svn path=/trunk/kdepim/; revision=236540
1) Remove the limitation that a message can have only one status at a time.
2) Implement watch/ignore thread via message status flags.
ad 1:
- Message status is now kept as a bitfield, which means a message can now be
for example replied and forwarded as well as important at the same time.
- To keep the index format backward compatible and make the transition
painless, I've added a new index entry and added code to transfer the old
into the new format. That means that upgrading users should not notice
anything.
- I've tried to keep as much behavior as possible unchanged with regard to
what flag disables what other flag etc. There are two groups of flags:
read/unread/new/old influence each other, which means a message cannot be
new and read at the same time, for example, while the second group, namely
important, sent, queued, replied, and forwarded are toggled individually.
- Toggling a thread sets the messages status to the inverse of that of the
parent, which means that if you have a thread with some mails marked as
important and some not, the status is set according to that of the parent.
- Status is now kept when moving mails between folders in the same imap
account as well as between imap accounts.
ad 2:
- Watch and ignore are mutually exclusive, which means ignoring a thread
unsets its watched flag and the other way around.
- When sorting by status watched threads are at the top, ignored at the
bottom.
- Watch and ignore propagate via threading, which means that if a message
is threaded below a watched one, it becomes watched. Same for ignore.
- Moving a single mail out of a watched thread results in a new watched
thread of size 1 :)
- Similarly watch and ignore are possible on individual mail (threads
to be).
- Watching a thread does not currently mark new mails as important, nor
does ignoring delete new mails in the thread. These are possible
extensions, though, if we think them sensible.
svn path=/trunk/kdepim/; revision=235595
- Strip own address from list of recipients when using the Mail-followup-to header.
- Don't add addresses to the Cc header which are already in the To header.
- New functions:
static QStringList stripAddressFromAddressList( const QString& address, const QStringList& addresses )
/** Strips an address from an address list. This is for example used when replying to all. */
static bool addressIsInAddressList( const QString& address, const QStringList& addresses )
/** Returns true if the given address is contained in the given address list. */
svn path=/trunk/kdepim/; revision=230219
KMail::UndoStack.
Waldo, would you mind if I added the Qt clause which we discussed some time ago
on the KMail list to the undostack.{h,cpp} files?
CCMAIL: Waldo Bastian <bastian@kde.org>
svn path=/trunk/kdepim/; revision=227174
dded KMMessage::fromByteArray(). Uses less memory (no intermediate QCString built) and fixes the off-by-one error in a central place.
svn path=/trunk/kdepim/; revision=226543
To Sven: follow the style of the file to which you are committing.
To all others: removing printf's and switching some asserts.
To myself: you got a nice butt.
svn path=/trunk/kdepim/; revision=223697
o KMMessage::headerAddrField() now returns a AddressList instead of a string list.
o New method KMMessage::extractAddrSpecs() returns a AddrSpecList (used in sender)
=> Now KMail copes with empty groups while sending (undisclosed recipients: ;)
Using new kio_smtp features:
o Dump prepareString() for KDE_IS_VERSION( 3, 1, 90 )
o Instruct slave to perform dotstuffing and lf->crlf conversion
o Adapt to KMMessage::headerAddrField() signature change
o Use mMessageLength * 1.05 for size declaration instead of KMMessage::msgLength()
svn path=/trunk/kdepim/; revision=222632
This was really a stupid bug:
- isHTML = DwMime::kSubtypeHtml == curNode->type();
+ isHTML = DwMime::kSubtypeHtml == curNode->subType();
- Use the correct charset for replies to PGP/MIME encrypted messages.
- Get rid of a some duplicate code.
Backport is pending.
svn path=/trunk/kdepim/; revision=215868
Ingo Klcker
Carsten Burghardt
Till Adam
Stephan Kulow
Don Sanders
Marc Mutz
Helge Deller
George Staikos
Zack Rusin
Cornelius Schumacher
Laurent Montel
Scott Wheeler
Antonio Larrosa Jimenez