information about the folder, its file and index locations and sizes, and the
content and messages.
For mbox folders, the compaction state and a button to do it is here (still
also in the folder context menu). A folder can be compacted (at the user's
own risk) even if it was previously marked "unsafe".
Other dangerous operations ("Rebuild Index" and "Rebuild IMAP Cache") have
been moved from the context/menubar menus to here.
Moved the "mark_all_as_read" action back to the top of the folder popup menu,
as suggested by aseigo.
Added some hooks (KMFolderDialog::setPage() and KMMainWidget::PropsPage enum)
to embed the other folder properties into this dialogue, if there can ever be
agreement on the usability of this. So it's not a fix for bug 115611, but it's
a start...
CCBUG:115611
svn path=/trunk/KDE/kdepim/; revision=927964
This brings a reworked folder tree and and a new message list, which is much more powerful than the old one.
New features include grouping, multiline items and the ability to customize just about everything of the look of the message list.
Also, we have a tabbed interface for opening more than one folder at once now.
An important aspect of the new message list is that drawing speed is now fast again (there was a regression in Q3ListView that
made huge folders a real pain to navigate, reading commit folders was not a nice thing to do).
There are probably more things which I forgot to list here.
Also, this is big step forward in getting rid of Qt3Support in KMail, now just some tiny bits are left.
Many thanks to SoC student Szymon Stefanek for his awesome work on his project! I can't stress enough how great this
achivment is. He even added very good API documentation to his classes :)
This requires the lastest version of qt-copy, otherwise you'll get mysterious crashes in Qt painting code from time to time.
We hope that this patch will be added to the next Qt 4.4.x version.
And finally, this merge also brings many regressions, which is not unnatural for such a big change.
In the remaining time before the KDE 4.2 release, we'll have to work on those to get it polished and regression-free.
Help here is always needed, and is a good opportunity to start working on KMail, since many regressions are low hanging fruit.
It also means the message list and the folder tree need a bit of testing.
If you find bugs, report them under the "new message list" and "new folder tree" component of the bug tracker, thanks.
I also plan to setup a wiki page with known regressions.
CCMAIL: kde-pim@kde.org
GUI:
CCBUG: 117808
BUG: 163469
FEATURE: 18170
FEATURE: 32400
FEATURE: 42107
FEATURE: 45526
FEATURE: 81272
FEATURE: 90142
FEATURE: 107450
(and probably many others)
svn path=/trunk/KDE/kdepim/; revision=881321
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
................
r860059 | vkrause | 2008-09-11 22:43:32 +0200 (Thu, 11 Sep 2008) | 21 lines
Merged revisions 859561,860036 via svnmerge from
https://vkrause@svn.kde.org/home/kde/branches/kdepim/enterprise/kdepim
........
r859561 | vkrause | 2008-09-10 19:10:02 +0200 (Wed, 10 Sep 2008) | 5 lines
Reload the folder tree if a folder type changes, we have a few folder
hiding options that depend on it.
Kolab issue 2792 (part 1)
........
r860036 | vkrause | 2008-09-11 22:06:02 +0200 (Thu, 11 Sep 2008) | 7 lines
Reload the folder tree on changes to no content state of any folder,
visible or hidden. This ensures that previous no content and thus
possibly hidden folders are shown correctly after the owner provides us
with read access on such a folder.
Kolab issue 2792 (part 2)
........
................
svn path=/trunk/KDE/kdepim/; revision=860257
https://vkrause@svn.kde.org/home/kde/branches/kdepim/enterprise/kdepim
........
r859561 | vkrause | 2008-09-10 19:10:02 +0200 (Wed, 10 Sep 2008) | 5 lines
Reload the folder tree if a folder type changes, we have a few folder
hiding options that depend on it.
Kolab issue 2792 (part 1)
........
r860036 | vkrause | 2008-09-11 22:06:02 +0200 (Thu, 11 Sep 2008) | 7 lines
Reload the folder tree on changes to no content state of any folder,
visible or hidden. This ensures that previous no content and thus
possibly hidden folders are shown correctly after the owner provides us
with read access on such a folder.
Kolab issue 2792 (part 2)
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=860059
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
................
r854399 | vkrause | 2008-08-29 15:04:19 +0200 (Fri, 29 Aug 2008) | 13 lines
Merged revisions 850513 via svnmerge from
https://vkrause@svn.kde.org/home/kde/branches/kdepim/enterprise/kdepim
........
r850513 | vkrause | 2008-08-21 19:11:57 +0200 (Thu, 21 Aug 2008) | 6 lines
Allow deletion of message only if the IMAP ACLs allow it. The current
code assumed that deletion was not possible iff a folder is read-only,
which is too simple for IMAP.
Kolab issue 2954
........
................
svn path=/trunk/KDE/kdepim/; revision=855221
svn+ssh://tmcguire@svn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim
........
r853982 | vkrause | 2008-08-28 17:31:55 +0200 (Thu, 28 Aug 2008) | 13 lines
Forwardport SVN commit 662047 by tilladam from enterprise branch:
Apply ported version of the mail loss debugging and explicit deletions patch,
which I've been developing with the help of some adventurous users. Thanks!
This tracks all deletions that happen through user actions and adds a check
to the sync making sure that only things that were explicitely deleted
are removed during sync. If unsure, the sync now re-downloads (duplicates)
instead of removing mails, which should be safer. Also adds a lot of
conditional debugging and refactors open/close to duplicate less code.
Will has a ported version of this for 3.x, which will go into pim+ shortly.
........
svn path=/trunk/KDE/kdepim/; revision=855193
https://vkrause@svn.kde.org/home/kde/branches/kdepim/enterprise/kdepim
........
r850513 | vkrause | 2008-08-21 19:11:57 +0200 (Thu, 21 Aug 2008) | 6 lines
Allow deletion of message only if the IMAP ACLs allow it. The current
code assumed that deletion was not possible iff a folder is read-only,
which is too simple for IMAP.
Kolab issue 2954
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=854399
Apply ported version of the mail loss debugging and explicit deletions patch,
which I've been developing with the help of some adventurous users. Thanks!
This tracks all deletions that happen through user actions and adds a check
to the sync making sure that only things that were explicitely deleted
are removed during sync. If unsure, the sync now re-downloads (duplicates)
instead of removing mails, which should be safer. Also adds a lot of
conditional debugging and refactors open/close to duplicate less code.
Will has a ported version of this for 3.x, which will go into pim+ shortly.
svn path=/branches/kdepim/enterprise4/kdepim/; revision=853982
* r829986: Don't fail when renaming the sorted file fails (and add some kWarnings in case of error). (bug 166023)
* r830027: Fix detection when to quit the main loop, implement cancelMailCheck() for POP accounts etc. (bug 163479)
* r830031: Make the location combobox editable again. (bug 166148)
CCMAIL: Thomas.McGuire@gmx.net
svn path=/branches/KDE/4.1/kdepim/; revision=830047
svn+ssh://svn.kde.org/home/kde/trunk/KDE/kdepim
........
r811955 | tstaerk | 2008-05-24 10:17:30 +0200 (Sat, 24 May 2008) | 1 line
test before you print debugging output
........
r811958 | tstaerk | 2008-05-24 10:56:51 +0200 (Sat, 24 May 2008) | 1 line
Do not ask twice
........
r811971 | tstaerk | 2008-05-24 11:32:16 +0200 (Sat, 24 May 2008) | 1 line
Finally remove the most confusing code I ever saw.
........
r812023 | tstaerk | 2008-05-24 14:40:11 +0200 (Sat, 24 May 2008) | 1 line
show correct times in the journal now after the date-related corrections
........
r812029 | tmcguire | 2008-05-24 14:45:02 +0200 (Sat, 24 May 2008) | 5 lines
Make the folderselection dialog slow again, otherwise the folder requester
crashes.
I'll write a testcase for this later, it seems to be another qt bug.
........
r812030 | tmcguire | 2008-05-24 14:47:31 +0200 (Sat, 24 May 2008) | 2 lines
Remove code duplication
........
r812173 | winterz | 2008-05-24 20:34:37 +0200 (Sat, 24 May 2008) | 3 lines
various micro optimizations that Krazy found for single char QStrings
better written as QChars.
........
r812177 | djarvie | 2008-05-24 20:41:16 +0200 (Sat, 24 May 2008) | 2 lines
Prevent user changing font/colour dialogue when editing read-only alarms
........
r812180 | winterz | 2008-05-24 20:52:53 +0200 (Sat, 24 May 2008) | 3 lines
various micro optimizations that Krazy found for single char QStrings
better written as QChars.
........
r812181 | danders | 2008-05-24 20:55:09 +0200 (Sat, 24 May 2008) | 6 lines
1) Fix crash when a constraintitem is deleted.
2) Add relations types FinishStart (default),
FinishFinish, StartStart and StartFinish.
3) Fix wrong assert.
4) Add month/week time scale.
........
r812183 | winterz | 2008-05-24 21:02:56 +0200 (Sat, 24 May 2008) | 3 lines
various micro optimizations that Krazy found for single char QStrings
better written as QChars.
........
r812212 | reed | 2008-05-24 23:00:42 +0200 (Sat, 24 May 2008) | 1 line
this icon does not exist at build time, causes an error on osx
........
r812283 | tstaerk | 2008-05-25 11:31:20 +0200 (Sun, 25 May 2008) | 1 line
secsPerMinute should be set by a central lib, no idletimedetector
........
r812288 | tstaerk | 2008-05-25 12:04:38 +0200 (Sun, 25 May 2008) | 1 line
Fighting entropy
........
r812293 | tstaerk | 2008-05-25 12:39:35 +0200 (Sun, 25 May 2008) | 1 line
I will not forget the ChangeLog
........
r812297 | tstaerk | 2008-05-25 12:51:44 +0200 (Sun, 25 May 2008) | 1 line
seconds per minute is everywhere the same (don't tell me about debugging)
........
r812298 | qbast | 2008-05-25 12:53:26 +0200 (Sun, 25 May 2008) | 5 lines
Fix for deleting articles in draft folder from inside composer. It makes
sure that composer is not double-deleted and uses deleteLater() because
you can't delete object from inside its own event handler.
........
r812301 | qbast | 2008-05-25 13:12:51 +0200 (Sun, 25 May 2008) | 4 lines
Fix badly copied&pasted slot definition in connect(). This makes knode
notice when external editor exits.
........
r812307 | qbast | 2008-05-25 13:32:25 +0200 (Sun, 25 May 2008) | 4 lines
When widget is not added to layout, visual results are quite hideous.
........
r812325 | tstaerk | 2008-05-25 14:43:33 +0200 (Sun, 25 May 2008) | 1 line
removing relicts
........
r812394 | winterz | 2008-05-25 15:32:27 +0200 (Sun, 25 May 2008) | 2 lines
fix server icon. thanks lemma
........
r812397 | winterz | 2008-05-25 15:33:47 +0200 (Sun, 25 May 2008) | 2 lines
fix icon "message_reply" -> "message-reply-all". thanks again lemma
........
r812420 | finex | 2008-05-25 15:47:35 +0200 (Sun, 25 May 2008) | 1 line
Disable buttonApply when there are zero templates
........
r812449 | scripty | 2008-05-25 15:59:17 +0200 (Sun, 25 May 2008) | 1 line
SVN_SILENT made messages (.desktop file)
........
r812469 | tmcguire | 2008-05-25 16:34:39 +0200 (Sun, 25 May 2008) | 6 lines
Get rid of embedded NUL characters in the string.
This fixes questionmarks appearing in the plain text version
of a multipart/alternative mail which had a multiline HTML
signature.
........
r812476 | winterz | 2008-05-25 16:52:31 +0200 (Sun, 25 May 2008) | 6 lines
fix <html>reminder spec</html> being shown in the offset column.
the problem is that @info tells KLocalizedString to create richtext.
so we use @item context marker instead which defaults to plain text.
........
r812487 | tmcguire | 2008-05-25 17:30:10 +0200 (Sun, 25 May 2008) | 2 lines
Remove unneeded newline from end of default reply and forward templates
........
r812517 | qbast | 2008-05-25 18:44:59 +0200 (Sun, 25 May 2008) | 4 lines
Prevent crashes when killing external editor and closing composer window
with external editor still running.
........
r812521 | qbast | 2008-05-25 19:03:08 +0200 (Sun, 25 May 2008) | 6 lines
Fix reading file back from external editor. When using QTextStream to
read file line-by-line, use QTextStrem::atEnd() instead of
QFile.atEnd(), because QTextStream may internally buffer some (or whole)
file.
........
r812697 | vkrause | 2008-05-26 08:24:16 +0200 (Mon, 26 May 2008) | 2 lines
Fix initial item listing in the maildir resource.
........
svn path=/branches/kdepim/enterprise4/kdepim/; revision=812708
- Enable some code again
- style fixes
Still totally broken, though.
Do not use a KMail version newer than the nommap branch merge.
svn path=/trunk/KDE/kdepim/; revision=805166
from
/branches/work/kmail-nommap (r799390..804487)
/branches/work/kdepim-nommap/kmail (r804484..804960)
The SQLite mode is currently enabled only on Windows (by KMAIL_SQLITE_INDEX define),
so on !Windows, the code for standard 'mmap' mode is compiled.
CCMAIL:kde-pim@kde.org
svn path=/trunk/KDE/kdepim/; revision=805075
- emit the closed() signal before calling folderMgr()->contentsChanged()
This fixes an refcount assert when calculating the unread count.
The assert would trigger there because the folder is closed with refcount 0
but still selected. Now, the headerview will open the folder before that, making
the refount 1.
- Don't show an error message when the old folder couldn't be unsubscribed. That error
message doesn't make sense, since the old folder does not exist anymore, and therefore
can't be unsubscribed anyway.
- Let the mainwidget re-open the folder after it is renamed. This fixes an assert when
switching away from an renamed folder, which would close it despite not having called open()
before.
- Also change the objectname when renaming, now renaming the same folder more than once works.
- tabs--
BUG: 158861
svn path=/trunk/KDE/kdepim/; revision=797025
but we should do the same with local messages.
If we accept serial number == 0, there can be more than one messages with uid == 0
and then we get assertion at korganizer's level because of duplicated uids.
svn path=/trunk/KDE/kdepim/; revision=795455
- The default identity is no longer 0, adopt to that
- To each account, add a new "Use Default Identity" checkbox. If it is checked,
the global default identity will be used. This way, changing the global default
identity actually changes the account identities as well.
svn path=/trunk/KDE/kdepim/; revision=772499
svn+ssh://pradeepto@svn.kde.org/home/kde/branches/kdepim/enterprise/kdepim
........
r739135 | tilladam | 2007-11-20 21:30:43 +0530 (Tue, 20 Nov 2007) | 6 lines
Add the ability to associate an identity with an account, such that that
identity is prefered when composing/replying etc, while in a folder of that
account. Folder-specific identities act as an override.
Prokde35-z Item 26
........
svn path=/trunk/KDE/kdepim/; revision=768464
svn+ssh://tilladam@svn.kde.org/home/kde/branches/KDE/3.5/kdepim
........
r650963 | winterz | 2007-04-06 00:51:52 +0200 (Fri, 06 Apr 2007) | 5 lines
merge SVN commit 647870 by coolo:
do not munge with open counts, but simply close and let
ticket owners reopen on closed( ) signal
........
svn path=/branches/kdepim/enterprise/kdepim/; revision=766769
Patch by Jean-Christophe Dubois <jcd at tribudubois dot net>, thanks!
This is a backport of rev. 751307 from trunk!
svn path=/branches/kdepim/enterprise/kdepim/; revision=760353
folders >2GB won't show up correctly on 32 Bit systems.
I hope I found all places were the conversion was necessary.
I couldn't really test this, as i don't have a 64 Bit system, but I should
work.
BUG: 151155
svn path=/trunk/KDE/kdepim/; revision=751020
were false positives.
There is one warning left, about slotInfoMessage
in QuotaJobs::GetQuotarootjo. This seems to be
real, as neither that slot nor the signal
connected to that slot seem to exist with that
signature.
It would be nice if someone with IMAP knowledge could
fix that.
svn path=/trunk/KDE/kdepim/; revision=747352
identity is prefered when composing/replying etc, while in a folder of that
account. Folder-specific identities act as an override.
Prokde35-z Item 26
svn path=/branches/kdepim/enterprise/kdepim/; revision=739135
for the new kDebug/kError/kWarning/kFatal syntax.
You can use the following command to find 'old' code:
egrep -r -A 5 '(kDebug|kError|kWarning|kFatal).*' * | grep -v ".svn" | grep "<< *endl;"
svn path=/trunk/KDE/kdepim/; revision=695781
keeping the msginfo pointer around in the message object, and restoring it on
unGet. Should help with a whole class of crashes around filtering, searching
etc. Original patch by Ingo and Andreas, with some fixes and memleak plugs
in corner cases by me. We'll testdrive this a while in enterprise branch, let's
see how it behaves.
CCMAIL: a.gungl@gmx.de
CCMAIL: ingo@kde.org
svn path=/branches/kdepim/enterprise/kdepim/; revision=694327
color for the folder name, to help improve the usability of working
with quota'd folders.
Resolves kolab merge item 22. Forward port of enterprise commits:
669156, 671804, 677689, 680527
svn path=/trunk/KDE/kdepim/; revision=691345
Jonathan Marten
Dirk Mueller
Laurent Montel
Thomas McGuire
Bertjan Broeksema
Volker Krause
David Faure
Marc Mutz
Allen Winter
Jarosaw Staniek
Pradeepto Bhattacharya
Till Adam
Andreas Hartmetz
Adriaan de Groot
Frank Osterfeld
Tobias Koenig
Daniel Molkentin