Fixes the following bug:
When an account is removed, the filters related to it get stuck in an infinite loop when KMail is restarted, preventing KMail from starting.
svn path=/trunk/KDE/kdepim/; revision=518076
When an account is removed, the filters related to it get stuck in an infinite loop when KMail is restarted, preventing KMail from starting.
BUG: 123342
svn path=/branches/KDE/3.5/kdepim/; revision=517670
sed 's/59 Temple Place - Suite 330, Boston, MA 02111-1307/51 Franklin Street, Fifth Floor, Boston, MA 02110-1301/'
PS: I didn't touch the kalarm dir, since david seems to update the address himself, and I don't want to create conflicts for him.
CCMAIL:lists@astrojar.org.uk
svn path=/trunk/KDE/kdepim/; revision=437921
incoming messages from IMAP accounts, that is messages that are delivered
into an IMAP inbox folder.
Sundry details:
I've modified these files:
kmfilterdlg.h kmfilterdlg.cpp
To add the advanced tab that allows per account filters
kmfilter.h kmfilter.cpp
I've added some new functions to KMFilter
setApplicability( AccountType )
AccountType applicability()
setApplyOnAccount( uint id, bool aApply )
bool applyOnAccount( uint id )
and an enum
enum AccountType { All, ButImap, Checked }
kmfiltermgr.h kmfiltermgr.cpp
I modified KMFilterMgr::process
to take two optional parameters
bool account = false
uint accountId = 0
and changed the implementation so that when these
params are set per account filtering is applied.
kmaccount.cpp
Trivially to use the new per account filtering.
kmacctimap.h kmacctimap.cpp
For 3 main reasons
1) In the case (it checks) that a filter applies to this
imap account, then incoming mails headers are
downloaded when mail checking occurs. Rather than waiting
until the folder is selected in the GUI.
Because it's really silly to have to select the inbox
folder to manually force filtering to kick in.
2) To load/save a list of unfiltered messages in the
constructor/destructor respectively.
3) To filter messages (I've sort of duplicated a little code
from kmheaders.cpp for this, my apologies).
kmfolderimap.cpp
1) To tell mAccount to filter new mail as the headers arrive.
This is basically the patch I've sent to bug:50997 several times and
has been available for testing for some time.
I'll now focus on allowing IMAP folders to be the target of the
Move Into Folder filter action, and less blocking filtering
(useful for piping into a spam tool).
CCMAIL:73758-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=408531
- Make KMFilterActionWithFolder::displayString() return the nice translated folder name instead of the internal folder name. Non-generic implementation of displayString() for the other filter actions will have to wait till after the string freeze.
- Use the new displayString() method for creating a nicer log message in the filter log.
svn path=/trunk/kdepim/; revision=391484
now written to the filter log viewer. This can help you to track down
problems with non-existing folders. The only way I see to get them into
kmailrc is to copy a configuration from somewhere else. KMail by itself
doesn't allow to specify non-existing folders as targets for filter
actions.
So at least the user can find out that something's wrong.
BUG: 95107
svn path=/trunk/kdepim/; revision=370453
was a problem in deciding which filters should be plugged
into the toolbar. As changing the filter dialog is
impossible because of the string freeze, the first approach
was to plug all shortcut filters into menu and toolbar.
Ingo suggested to plug only those shortcut filters into the
toolbar which have a non-default icon. So the user can control
the pluging even with the current dialog.
svn path=/branches/KDE_3_3_BRANCH/kdepim/; revision=343817
CVS commit by gungl:
Port the plugging of shortcut filters (AKA ad-hoc filters) into
menu and toolbar to the XMLGUI way.
svn path=/branches/KDE_3_3_BRANCH/kdepim/; revision=343708
menu and toolbar to the XMLGUI way.
Thanks to Till, David and Simon - that was an amazing teamwork.
CCMAIL: 87119-done@bugs.kde.org
CCMAIL: 82771-done@bugs.kde.org
svn path=/trunk/kdepim/; revision=343092
Implementing automagic mailing list handling: KMail can now detect whether
a folder stores a mailing list in which case it will try to determine its post,
subscribe, unsubscribe, archive and help addresses.
Aaron could you figure out where the kaction's invoking post,subscribe... could
be put?
CCMAIL: aseigo@kde.org
svn path=/trunk/kdepim/; revision=295216
better formatting of the log output (use QTextEdit::LogText),
avoid output of all headers for <any headers> filter rule
svn path=/trunk/kdepim/; revision=292936
very technical at the moment, and the possible user interactions are
still very limited. I'm going to improve this soon.
svn path=/trunk/kdepim/; revision=288302
The attached patch fixes the critical bug #71866.
From http://bugs.kde.org/show_bug.cgi?id=71866#c2:
"That's a prime example for why it's bad to store the value of an enum
as a number in a config file. The reason for this bug is a reordering
of the enum values in the code. This changed the meaning of the value
which is stored in the config file.
With the patch KMail stores the enum as a string representing the enum
value. As a consequence all POP filters will be reset to NoAction. But
there is no other fix possible because it's impossible to find out
whether the pop filter configuration was saved with KMail 1.6 or with a
previous version of KMail."
svn path=/trunk/kdepim/; revision=285082
This should fix a bug with ad hoc filters crashing when they move a message
to a different folder.
And also fix the bug/limitation that the move to folder action has to
come last in the list of filter actions for a filter.
This commit doesn't really use the action scheduler, code to use the
action scheduler in kmheaders and kmcommands is commented out.
I've been testing this code for a few weeks now. The changes to the
assignment operators in the kmmessage and kmmsgbase classes are the
changes I'm most concerned about here.
svn path=/trunk/kdepim/; revision=264912
- s/TRUE/true/ and s/FALSE/false/ in kmfilter.cpp
- replace deprecated KLineEditDlg by KInputDialog in kmfilterdlg.cpp
- fix a few What This texts in kmfilterdlg.cpp
svn path=/trunk/kdepim/; revision=262244
Arto Hytnen
Laurent Montel
Thomas McGuire
Matthias Kretz
David Faure
Allen Winter
Reinhold Kainhofer
Chusslove Illich
Ismail Onur Filiz
Andreas Gungl
Volker Krause
Till Adam
Thomas Zander
Don Sanders
Ingo Klcker
Andrew Coles
Zack Rusin
Ladislav Strojil